Skip to content

๐Ÿ”€ :: (#123) - modifybottom navigation design #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2024

Conversation

minStone-dev
Copy link
Contributor

@minStone-dev minStone-dev commented Jul 15, 2024

๐Ÿ” ์ด PR์„ ํ†ตํ•ด ํ•ด๊ฒฐํ•˜๋ ค๋Š” ๋ฌธ์ œ๊ฐ€ ๋ฌด์—‡์ธ๊ฐ€์š”?

์–ด๋–ค ๊ธฐ๋Šฅ์„ ๊ตฌํ˜„ํ• ๊ฑด์ง€, PR์ด ์—ด๋ฆฌ๊ฒŒ ๋œ ๊ณ„๊ธฐ์™€ ๋ชฉ์ ์„ Reviewer๋“ค์ด ์ดํ•ดํ•  ์ˆ˜ ์žˆ๊ฒŒ ์ ์–ด์ฃผ์„ธ์š”.

  • ๋ฐ”ํ…€ ๋„ค๋น„๊ฒŒ์ด์…˜ ๋””์ž์ธ ์ˆ˜์ • ๋ฐ ํ˜„์žฌ ์œ„์น˜ ํ‘œ์‹œ ๊ธฐ๋Šฅ ์ถ”๊ฐ€

โœจ ์ด PR์—์„œ ํ•ต์‹ฌ์ ์œผ๋กœ ๋ณ€๊ฒฝ๋œ ์‚ฌํ•ญ์€ ๋ฌด์—‡์ธ๊ฐ€์š”?

๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜๋ฉด์„œ ์ฃผ์š”ํ•˜๊ฒŒ ๋ณ€๊ฒฝ๋œ ์‚ฌํ•ญ์„ ์ ์–ด์ฃผ์„ธ์š”.

  • ๋ฐ”ํ…€ ๋„ค๋น„๊ฒŒ์ด์…˜ ๋””์ž์ธ ์ˆ˜์ • ๋ฐ ํ˜„์žฌ ์œ„์น˜ ํ‘œ์‹œ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
Screen_Recording_20240715_122302_StackKnowledge.mp4

๐Ÿ”– ํ•ต์‹ฌ ๋ณ€๊ฒฝ ์‚ฌํ•ญ ์ด์™ธ์— ์ถ”๊ฐ€์ ์œผ๋กœ ๋ณ€๊ฒฝ๋œ ๋ถ€๋ถ„์ด ์žˆ๋‚˜์š”?

์—†์œผ๋ฉด "์—†์Œ"์ด๋ผ๊ณ  ๊ธฐ์žฌํ•ด์ฃผ์„ธ์š”.

๐Ÿง Review ์‹œ ์ด๋Ÿฐ ๋ถ€๋ถ„์„ ์‹ ๊ฒฝ์จ์„œ ๋ด์ฃผ์‹œ๋ฉด ์ข‹๊ฒ ์–ด์š”

๊ฐœ๋ฐœ ๊ณผ์ •์—์„œ ๋‹ค๋ฅธ ๋ถ„์˜ ์˜๊ฒฌ์ด ๊ถ๊ธˆํ•˜๊ฑฐ๋‚˜ ํฌ๋กœ์Šค ์ฒดํฌ๊ฐ€ ํ•„์š”ํ•˜๋‹ค๊ณ  ๋А๊ปด์ง„ ์ฝ”๋“œ๊ฐ€ ์žˆ๋‹ค๋ฉด ๋‚จ๊ฒจ์ฃผ์„ธ์š”.

@minStone-dev minStone-dev self-assigned this Jul 15, 2024
@minStone-dev minStone-dev linked an issue Jul 15, 2024 that may be closed by this pull request
Copy link
Contributor

@yeongun130 yeongun130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค๐Ÿ‘ ํ˜น์‹œ ์ˆ˜์ •๋œ ๋ฐ”ํ…€๋„ค๋น„๊ฒŒ์ด์…˜ ์บก์ณํ•ด์„œ ์˜ฌ๋ ค์ฃผ์‹ค ์ˆ˜ ์žˆ๋‚˜์š”?

@minStone-dev minStone-dev merged commit 516ade0 into develop Jul 15, 2024
1 check passed
@minStone-dev minStone-dev deleted the feature/123-modifybottom-navigation-design branch July 15, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modifyBottom navigation design
2 participants