Skip to content

๐Ÿ”€ :: (#123) - modifybottom navigation design #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,21 @@ package com.minstone.ui.navigation
import androidx.compose.foundation.Image
import androidx.compose.foundation.background
import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.height
import androidx.compose.material3.Divider
import androidx.compose.material3.NavigationBar
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.ColorFilter
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.unit.dp
Expand All @@ -33,42 +37,51 @@ enum class NavigateType(val value: String) {
fun StackKnowledgeBottomNavigation(
modifier: Modifier,
role: Authority,
locate: NavigateType,
onNavigate: (String) -> Unit,
) {
StackKnowledgeAndroidTheme { colors, typography ->
Box(
modifier = modifier.background(color = colors.WHITE),
contentAlignment = Alignment.BottomCenter
) {
Row(
modifier = modifier
.fillMaxWidth()
.height(56.dp),
verticalAlignment = Alignment.CenterVertically
) {
val navItems = listOf(
Triple(R.drawable.home_icon, NavigateType.HOME.value, R.string.home),
Triple(R.drawable.mission_icon, NavigateType.MISSION.value, if(role == Authority.ROLE_STUDENT) R.string.mission else R.string.solved_mission),
Triple(R.drawable.create_mission_icon, NavigateType.CREATE_MISSION.value, R.string.create_mission),
Triple(R.drawable.shop_icon, NavigateType.SHOP.value, R.string.shop),
Triple(R.drawable.ranking_icon, NavigateType.RANKING.value, R.string.ranking)
Column {
Divider(
modifier = Modifier.fillMaxWidth(),
color = Color(0xFFF1F1F1)
)
Row(
modifier = modifier
.fillMaxWidth()
.height(56.dp),
verticalAlignment = Alignment.CenterVertically
) {
val navItems = listOf(
Triple(R.drawable.home_icon, NavigateType.HOME.value, R.string.home),
Triple(R.drawable.mission_icon, NavigateType.MISSION.value, if(role == Authority.ROLE_STUDENT) R.string.mission else R.string.solved_mission),
Triple(R.drawable.create_mission_icon, NavigateType.CREATE_MISSION.value, R.string.create_mission),
Triple(R.drawable.shop_icon, NavigateType.SHOP.value, R.string.shop),
Triple(R.drawable.ranking_icon, NavigateType.RANKING.value, R.string.ranking)
)

navItems.forEachIndexed { index, (iconRes, navigateType, stringResId) ->
if (index != 2 || role == Authority.ROLE_TEACHER) {
BottomNavigationComponent(
modifier = modifier
.weight(1f)
.height(56.dp),
buttonText = stringResId,
buttonImage = {
Image(
painter = painterResource(iconRes),
contentDescription = null
)
navItems.forEachIndexed { index, (iconRes, navigateType, stringResId) ->
if (index != 2 || role == Authority.ROLE_TEACHER) {
BottomNavigationComponent(
modifier = modifier
.weight(1f)
.height(56.dp),
buttonText = stringResId,
isLocate = locate.value == navigateType,
buttonImage = {
Image(
painter = painterResource(iconRes),
colorFilter = if(locate.value == navigateType) ColorFilter.tint(colors.P1) else null,
contentDescription = null
)
}
) {
onNavigate(navigateType)
}
) {
onNavigate(navigateType)
}
}
}
Expand All @@ -81,20 +94,22 @@ fun StackKnowledgeBottomNavigation(
private fun BottomNavigationComponent(
modifier: Modifier,
buttonText: Int,
isLocate: Boolean,
buttonImage: @Composable () -> Unit,
onClick: () -> Unit
) {
StackKnowledgeAndroidTheme { colors, typography ->
Column(
modifier = modifier.clickable(onClick = onClick),
horizontalAlignment = Alignment.CenterHorizontally
horizontalAlignment = Alignment.CenterHorizontally,
verticalArrangement = Arrangement.Center
) {
buttonImage()
Spacer(modifier = Modifier.height(5.dp))
Text(
text = stringResource(id = buttonText),
style = typography.bodySmall,
color = colors.BLACK
color = if (isLocate) colors.P1 else colors.BLACK
)
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ private fun MainPageScreen(
) {
StackKnowledgeBottomNavigation(
modifier = Modifier,
locate = NavigateType.HOME,
role = role
) {
onNavigate(it, null)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import androidx.hilt.navigation.compose.hiltViewModel
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import com.example.common.toast.makeToast
import com.example.common.util.Event
import com.minstone.ui.navigation.NavigateType
import com.minstone.ui.navigation.StackKnowledgeBottomNavigation
import com.stackknowledge.design_system.R
import com.stackknowledge.design_system.component.dialog.StackKnowledgeDialog
Expand Down Expand Up @@ -205,6 +206,7 @@ private fun CreateMissionScreen(
) {
StackKnowledgeBottomNavigation(
modifier = Modifier,
locate = NavigateType.CREATE_MISSION,
role = role
) {
onNavigate(it)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import androidx.compose.ui.Modifier
import androidx.compose.ui.platform.LocalContext
import androidx.hilt.navigation.compose.hiltViewModel
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import com.minstone.ui.navigation.NavigateType
import com.minstone.ui.navigation.StackKnowledgeBottomNavigation
import com.stackknowledge.design_system.component.topbar.StackKnowledgeTopBar
import com.stackknowledge.design_system.theme.StackKnowledgeAndroidTheme
Expand Down Expand Up @@ -77,6 +78,7 @@ private fun EntireMissionScreen(
) {
StackKnowledgeBottomNavigation(
modifier = Modifier,
locate = NavigateType.MISSION,
role = role
) {
onNavigate(it)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import androidx.hilt.navigation.compose.hiltViewModel
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import com.example.common.toast.makeToast
import com.example.common.util.Event
import com.minstone.ui.navigation.NavigateType
import com.minstone.ui.navigation.StackKnowledgeBottomNavigation
import com.stackknowledge.design_system.component.dialog.StackKnowledgeDialog
import com.stackknowledge.design_system.component.topbar.StackKnowledgeTopBar
Expand Down Expand Up @@ -232,6 +233,7 @@ private fun ResolveMissionScreen(
) {
StackKnowledgeBottomNavigation(
modifier = Modifier,
locate = NavigateType.MISSION,
role = role
) {
onNavigateState = it
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import androidx.compose.ui.Modifier
import androidx.compose.ui.unit.dp
import androidx.hilt.navigation.compose.hiltViewModel
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import com.minstone.ui.navigation.NavigateType
import com.minstone.ui.navigation.StackKnowledgeBottomNavigation
import com.stackknowledge.design_system.component.topbar.StackKnowledgeTopBar
import com.stackknowledge.design_system.theme.StackKnowledgeAndroidTheme
Expand Down Expand Up @@ -85,6 +86,7 @@ private fun RankingScreen(
) {
StackKnowledgeBottomNavigation(
modifier = Modifier,
locate = NavigateType.RANKING,
role = role
) {
onNavigate(it)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import androidx.compose.ui.Modifier
import androidx.compose.ui.unit.dp
import androidx.hilt.navigation.compose.hiltViewModel
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import com.minstone.ui.navigation.NavigateType
import com.minstone.ui.navigation.StackKnowledgeBottomNavigation
import com.stackknowledge.design_system.component.topbar.StackKnowledgeTopBar
import com.stackknowledge.design_system.theme.StackKnowledgeAndroidTheme
Expand Down Expand Up @@ -73,6 +74,7 @@ private fun TeacherRankingScreen(
) {
StackKnowledgeBottomNavigation(
modifier = Modifier,
locate = NavigateType.RANKING,
role = role
) {
onNavigate(it)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import androidx.compose.ui.unit.dp
import androidx.hilt.navigation.compose.hiltViewModel
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import com.example.common.util.Event
import com.minstone.ui.navigation.NavigateType
import com.minstone.ui.navigation.StackKnowledgeBottomNavigation
import com.stackknowledge.design_system.R
import com.stackknowledge.design_system.component.dialog.StackKnowledgeDialog
Expand Down Expand Up @@ -152,6 +153,7 @@ private fun GradingAnswerScreen(
) {
StackKnowledgeBottomNavigation(
modifier = Modifier,
locate = NavigateType.MISSION,
role = role
) {
onNavigate(it)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import androidx.compose.ui.Modifier
import androidx.compose.ui.platform.LocalContext
import androidx.hilt.navigation.compose.hiltViewModel
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import com.minstone.ui.navigation.NavigateType
import com.minstone.ui.navigation.StackKnowledgeBottomNavigation
import com.stackknowledge.design_system.component.topbar.StackKnowledgeTopBar
import com.stackknowledge.design_system.theme.StackKnowledgeAndroidTheme
Expand Down Expand Up @@ -76,6 +77,7 @@ private fun SolvedMissionScreen(
) {
StackKnowledgeBottomNavigation(
modifier = Modifier,
locate = NavigateType.MISSION,
role = role
) {
onNavigate(it)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import androidx.hilt.navigation.compose.hiltViewModel
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import com.minstone.ui.navigation.NavigateType
import com.minstone.ui.navigation.StackKnowledgeBottomNavigation
import com.stackknowledge.design_system.R
import com.stackknowledge.design_system.component.dialog.StackKnowledgeDialog
Expand Down Expand Up @@ -117,6 +118,7 @@ private fun ShopScreen(
) {
StackKnowledgeBottomNavigation(
modifier = Modifier,
locate = NavigateType.SHOP,
role = role
) {
onNavigate(it)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import androidx.compose.ui.platform.LocalContext
import androidx.compose.ui.res.stringResource
import androidx.hilt.navigation.compose.hiltViewModel
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import com.minstone.ui.navigation.NavigateType
import com.minstone.ui.navigation.StackKnowledgeBottomNavigation
import com.stackknowledge.design_system.R
import com.stackknowledge.design_system.component.dialog.StackKnowledgeDialog
Expand Down Expand Up @@ -93,6 +94,7 @@ private fun TeacherShopScreen(
) {
StackKnowledgeBottomNavigation(
modifier = Modifier,
locate = NavigateType.SHOP,
role = role
) {
onNavigate(it)
Expand Down
Loading