Skip to content

Conversation

@vishwa2710
Copy link
Contributor

@vishwa2710 vishwa2710 commented Jul 7, 2025

#59

@Stoops-ML
Copy link
Owner

Tests fail. @vishwa2710 would you like to update test_position_list_with_references()? If not, I can.

@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.80%. Comparing base (cec8e40) to head (d9c8778).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   99.74%   99.80%   +0.06%     
==========================================
  Files           9        9              
  Lines        1585     1562      -23     
==========================================
- Hits         1581     1559      -22     
+ Misses          4        3       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vishwa2710
Copy link
Contributor Author

Hey @Stoops-ML , let me know what you think, tests should pass now and code is formatted.
From what I understand from the CZML spec, there should only be 1 value provided for the cartesians/references for a defined position.

@Stoops-ML
Copy link
Owner

The changes to the properties looks good.

The coverage needs to be bumped up a little. The following properties aren't covered by the tests following the changes:

  • CartographicRadiansListOfListsValue
  • Cartesian3ListValue
  • Cartesian3ListOfListsValue

@vishwa2710
Copy link
Contributor Author

The changes to the properties looks good.

The coverage needs to be bumped up a little. The following properties aren't covered by the tests following the changes:

  • CartographicRadiansListOfListsValue
  • Cartesian3ListValue
  • Cartesian3ListOfListsValue

Thanks for pointing that out!
I added new tests explicitly so that the coverage was not implicit from the reference based tests. Hope that's okay!

@Stoops-ML Stoops-ML merged commit 3c6b094 into Stoops-ML:main Jul 8, 2025
7 checks passed
@Stoops-ML
Copy link
Owner

v2.3.5 released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants