-
Notifications
You must be signed in to change notification settings - Fork 3
fix: PositionList reference parsing #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tests fail. @vishwa2710 would you like to update |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
+ Coverage 99.74% 99.80% +0.06%
==========================================
Files 9 9
Lines 1585 1562 -23
==========================================
- Hits 1581 1559 -22
+ Misses 4 3 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hey @Stoops-ML , let me know what you think, tests should pass now and code is formatted. |
|
The changes to the properties looks good. The coverage needs to be bumped up a little. The following properties aren't covered by the tests following the changes:
|
Thanks for pointing that out! |
|
v2.3.5 released! |
#59