✨ Feat: Auto scroll when dragging #262
Merged
+143
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `gridScrollRef` and replace with `mainGridRef`. Having `gridScrollRef` as a separate entity and having `mainGridRef` as a callback function that is not a ref and does not return a ref did not makes sense to me. I believe this change makes the code simpler and more readable. - Remove unused `react-merge-refs` dependency as a consequence of above change - Handle few TS errors
that-one-arab
force-pushed
the
feature_smart_scroll_when_dragging
branch
from
5790944 to
44abdea
Compare
…he page, causing event to overflow past container. Refactor code this occurs when we drag an event to the very bottom until the event's end time is past midnight, instead of preventing me from dragging the event past midnight, the event overflows past its container.
that-one-arab
force-pushed
the
feature_smart_scroll_when_dragging
branch
from
ea3ff50 to
c80757d
Compare
that-one-arab
changed the title
tyler-dane
changed the title
without this, the main grid would screen when dragging an all-day event
This was referenced Feb 20, 2025
tyler-dane
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes issue
This PR implements an auto scroll feature to auto scroll the user when they drag an event to the bottom or top edge of the main grid area.
It handled refactoring parts of the code along the way, mainly removing
gridScrollRefto simplify the code.It also handled fixing a bug caused by an edge case that was always present, but became more apparent with this new feature. The bug is: when dragging an event to the very bottom of the screen, you can place the event in a way that the end date would overflow outside the bottom edge of the main grid area container. Details in below video:
Summary:
gridScrollRefIntroduces known bugs: #267 #266
Videos
Before
auto_scroll_event_overflow_jittering_before.webm
auto_scroll_before.webm
After
auto_scroll_event_overflow_jittering_after.webm
auto_scroll_after.webm