Repository navigation
chore: remove unused legacy code - #27
Merged
Merged
Conversation
Remove the unreferenced TrackCombiner utility and five one-off asset generator scripts whose output is already committed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove an unreferenced utility class and five one-off asset generator scripts.
utils/TrackCombiner: its only method,getCombinedTracks, is never called or referenced anywhere in the workspace.scripts/gen_potato_rotten.py,scripts/gen_sausage_items_yaml.py,scripts/gen_sausage_models.py,scripts/gen_sausage_variants.pyandscripts/gen_yeast_dough_rotten.py: one-off generators for resource-pack textures, models and an ItemsAdder YAML block. Their output (the rotten potato and yeast dough assets and the sausage/sausage-chain models, textures and item definitions) is already committed underItemsAdder/tfmc_cooking, and nothing runs them. The documentation scripts inscripts/are unchanged.LegacyFish classes, husbandry fallbacks and all resource-pack assets are untouched.
Evidence: searched every repository under the TF-Minecraft workspace (main and test sources, YAML, workflows, README,
docs/and other scripts, excluding.git) for each class and script name. The only matches were the definitions themselves.Documentation impact: none of the removed paths is owned in
docs/manifest.json, so no system doc or waiver change is needed;scripts/check-doc-impact.pypasses againstmainwithout one.Validation:
scripts/test_doc_manifest.py,scripts/check-links.pyandscripts/check-doc-impact.pypass locally;git diff --checkpasses; the diff is deletions only. No local Maven is available, so the standard PR build, tests and JAR verification are the build gate.🤖 Generated with Claude Code