Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Email address relationship #46 #49

Merged
merged 4 commits into from
Mar 24, 2021
Merged

Update Email address relationship #46 #49

merged 4 commits into from
Mar 24, 2021

Conversation

chx2
Copy link
Contributor

@chx2 chx2 commented Mar 23, 2021

As stated in my updated comments in #31, tests will fail since the references in the AttachContactUsersCommand need to be updated to reflect how email is now setup

@chx2 chx2 requested a review from drewroberts March 23, 2021 02:24
@drewroberts
Copy link
Member

@chx2 Let's go ahead and remove the AttachContactUsersCommand from this package in this PR. With the new Email Address model (TIPOFF/authorization#57), we will now know the User (TIPOFF/authorization#20) for the Contact (#30) through that relationship since Email Address has a nullable user_id and will be updated when a user is created with that Email Address.

@chx2
Copy link
Contributor Author

chx2 commented Mar 23, 2021

Removed AttachContactUsers Command

drewroberts
drewroberts approved these changes Mar 24, 2021
View reviewed changes
Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🏊

@drewroberts drewroberts merged commit 3bff67f into main Mar 24, 2021
@drewroberts drewroberts deleted the chx2/feature/46-email-address branch March 24, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewroberts drewroberts drewroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chx2 @drewroberts