Enh/add reactions #1565
Open
Enh/add reactions #1565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kordianbruck
requested changes
Jun 5, 2025
| CustomMessage: "user not eligible to watch course", | ||
| }) | ||
| return | ||
| } |
Member
There was a problem hiding this comment.
optional: these three conditionals seem like they could be a separate function that could be reused?
Collaborator
Author
There was a problem hiding this comment.
I will leave them there for now and they can be extracted if we need them somewhere else
| go func() { | ||
| // Notify admins every 5 seconds | ||
| logger.Info("Starting periodic notification of reaction percentages") | ||
| for { |
Member
There was a problem hiding this comment.
Isn't this a leaking goroutine? You never end it or cancel it via a context?
Collaborator
Author
There was a problem hiding this comment.
This should be ok as this is only started once at the initialize and it will be stopped when the program stops.
Merged
SebiWrn
force-pushed
the
enh/add-reactions
branch
from
24c748f to
9d4356f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This pull request adds previously mentioned reactions by students (look at #1564).
Closes #127.
The percentage below the reactions shows the usage in the last few minutes.
Available reactions can be modified in the config.yaml.
Important
Do not merge before #1564 !!
Screenshots