-
Notifications
You must be signed in to change notification settings - Fork 61
fix(U-Boot): Correct R5 SPL core for J722S #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
In J722S boot flow, R5 SPL runs on the MCU domain R5 and not the MAIN domain R5. Correct this by adding a separate boot flow diagram for J72SS as it's flow is different from any of the others. Fixes: e557295 ("J722S: Add doc support for J7AEN") Reported-by: Diwakar Dhyani <[email protected]> Signed-off-by: Neha Malcom Francis <[email protected]>
@@ -1722,6 +1722,79 @@ Boot Flow | |||
Here |__SYSFW_CORE_NAME__| acts as master and provides all the critical services. R5/ARM64 | |||
requests |__SYSFW_CORE_NAME__| to get these services done as shown in the above diagram. | |||
|
|||
.. ifconfig:: CONFIG_part_variant in ('J722S') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I don't really like the size of this diff compared to the amount of content actually changing, but that's not really that big of an issue I guess.
I am concerned as to why this is applicable to J722S but not AM62P. @bryanbrattlof @h-nagalla can you comment? At this point I think the original table being copied here was also using the wrong nomenclature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Humm.. I believe for both devices DMR5 is in WKUP domain. Check this pds doc:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h-nagalla public list. removed the pds link reference ( not accesible from here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this ROM code is heavily recycled from the 62A/62P Sitara class of SoCs which use a somewhat dedicated R5 core in the 'Wakeup Island" (sometimes called the Device Manger core) for the Public ROM code as well as for DM after U-Boot has finished booting with it.
We could probably do a better job of calling this out in the TRM, but check out chapter 7.4.1 for a little more on the roles the WKUP_R5FSS plays during boot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nehamalcom any update on this PR closure
In J722S boot flow, R5 SPL runs on the MCU domain R5 and not the MAIN domain R5. Correct this by adding a separate boot flow diagram for J72SS as it's flow is different from any of the others.
Fixes: e557295 ("J722S: Add doc support for J7AEN")
Reported-by: Diwakar Dhyani [email protected]
Signed-off-by: Neha Malcom Francis [email protected]