Skip to content

[GEN][ZH] Fix China Hackers unnecessarily packing and unpacking when ordered to hack while already hacking #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2025
Merged

[GEN][ZH] Fix China Hackers unnecessarily packing and unpacking when ordered to hack while already hacking #1280

merged 1 commit into from
Jul 17, 2025

Conversation

Mauller
Copy link

@Mauller Mauller commented Jul 14, 2025 •
edited
Loading

This PR is an alternate / updated implementation of an earlier orphaned PR

This PR prevents hackers that are currently hacking from packing then unpacking again when told to hack the internet.
This often occurs when they are part of a selection of hackers which are idling or hacking and are ordered to hack the internet.

@Mauller Mauller self-assigned this Jul 14, 2025
@Mauller Mauller added Bug Something is not working right, typically is user facing Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour NoRetail This fix or change is not applicable with Retail game compatibility labels Jul 14, 2025
@Mauller Mauller added this to the Major bug fixes milestone Jul 14, 2025
Caball009
Caball009 approved these changes Jul 15, 2025
View reviewed changes
Copy link

@Caball009 Caball009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended.

@Mauller Mauller force-pushed the fix-hackers-pack-unpack branch from 2c10734 to eb09fa1 Compare July 15, 2025 18:31
@Mauller
Copy link
Author

Mauller commented Jul 15, 2025

Tweaked with const on the stateID variable

@xezon xezon changed the title [GEN][ZH] Fix hacking hackers packing and unpacking when ordered to hack the Internet [GEN][ZH] Fix China Hackers unnecessarily packing and unpacking when ordered to hack while already hacking Jul 16, 2025
@xezon xezon removed this from the Major bug fixes milestone Jul 16, 2025
@xezon
Copy link

xezon commented Jul 16, 2025

Title tweaked.

@xezon xezon merged commit 11f49db into TheSuperHackers:main Jul 17, 2025
15 checks passed
@xezon xezon deleted the fix-hackers-pack-unpack branch July 17, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xezon xezon xezon approved these changes

@Caball009 Caball009 Caball009 approved these changes

Assignees

@Mauller Mauller

Labels
Bug Something is not working right, typically is user facing Gen Relates to Generals Minor Severity: Minor < Major < Critical < Blocker NoRetail This fix or change is not applicable with Retail game compatibility ZH Relates to Zero Hour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

China Hackers pack and unpack unnecessarily when ordered to hack in a group
3 participants
@Mauller @xezon @Caball009