bugfix(scorches): Prevent gameplay scorches from evicting map scorches - #3114
Open
stephanmeesters wants to merge 2 commits into
Open
bugfix(scorches): Prevent gameplay scorches from evicting map scorches#3114stephanmeesters wants to merge 2 commits into
stephanmeesters wants to merge 2 commits into
Conversation
stephanmeesters
added
Rendering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a separate instance of
W3DScorchto be used only for "static" scorch marks placed on a map using World Builder. This fixes the issue that these static scorches eventually disappear during gameplay.By using the separate instance of
W3DScorch, with its own GPU buffers, the static scorches will not have much performance impact: the buffer does not change often and is cheap to draw. The exception is changes to terrain geometry or changes to the map lighting, which invalidates all of the scorch buffers.Deduplication of static scorches is disabled, as dedup checking adds to map loading time (especially if we were to increase the max nr of scorches later), and we can trust map makers to place the scorch marks correctly.