fix: workflow

[ro80t]

Summary by CodeRabbit

• Chores
  • Adjusted automated preview workflow triggers so it runs only for relevant pull request activity and no longer on direct branch updates.
  • Updated preview execution rules to avoid unnecessary runs when a pull request is closed or when the workflow is started by a push event.

[github-actions]

Preview deployed to: https://ThunLights.github.io/distopia/storybook/pr-preview-91

[coderabbitai]

📝 Walkthrough

Walkthrough

The Storybook workflow now runs only for selected pull-request actions and no longer on push events. The preview job also skips push-triggered runs while continuing to skip closed pull-request actions.

Changes

Storybook workflow trigger update

Layer / File(s)	Summary
Pull request trigger scope .github/workflows/storybook.yml	pull_request is limited to opened, synchronize, reopened, and closed, and the push trigger is removed.
Preview job gating .github/workflows/storybook.yml	jobs.preview.if now also excludes github.event_name == 'push' while still excluding closed pull-request actions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• ThunLights/distopia#38: Also adjusts the Storybook workflow trigger and preview conditions in the same file.

Poem

A rabbit hopped by with a workflow cheer,
No push-triggered hops will wander here.
PR bells ring softly, then preview lights glow,
Closed bunnies rest while the Storybook grows.
🐇

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is too generic to clearly describe the workflow change.	Rename it to mention the specific workflow update, such as restricting Storybook workflow triggers to pull_request events.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-wf

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

.github/workflows/storybook.yml (1)

74-74: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Redundant push guard now that the push trigger is removed.

With the push trigger dropped from on, this workflow only fires on pull_request, so github.event_name != 'push' is always true and the clause is dead. You can simplify the condition to just exclude closed actions.

♻️ Optional simplification

-    if: github.event.action != 'closed' && github.event_name != 'push'
+    if: github.event.action != 'closed'

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/storybook.yml at line 74, The conditional on the Storybook
workflow job still includes a dead `github.event_name != 'push'` guard even
though the workflow no longer triggers on push events. Update the `if`
expression to only check the `github.event.action` state and remove the
redundant push exclusion, keeping the logic in the same workflow job where this
condition is defined.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In @.github/workflows/storybook.yml:
- Line 74: The conditional on the Storybook workflow job still includes a dead
`github.event_name != 'push'` guard even though the workflow no longer triggers
on push events. Update the `if` expression to only check the
`github.event.action` state and remove the redundant push exclusion, keeping the
logic in the same workflow job where this condition is defined.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b60420c4-3727-4649-94bb-9d9fba597567

📥 Commits

Reviewing files that changed from the base of the PR and between 9b8697f and 70b8602.

📒 Files selected for processing (1)

• .github/workflows/storybook.yml