Conversation
📝 WalkthroughWalkthroughThe PR updates setup caching and task behavior, changes the Playwright web server startup command, and adjusts Docker compose and Dockerfile runtime configuration. ChangesSetup, test, and caching updates
Docker runtime updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Preview deployed to: https://ThunLights.github.io/distopia/storybook/pr-preview-96 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/presentation/web/package.json`:
- Line 15: The setup script in package.json still invokes npm for the follow-up
Storybook build, which violates the Bun-only toolchain contract. Update the
setup command to call bun run build-storybook instead of npm run
build-storybook, keeping the existing Playwright install step intact and
preserving the current script name.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 4ed8a4fa-9262-4f73-a66c-9f2213d53968
📒 Files selected for processing (5)
.github/workflows/setup/action.ymldocker/docker-compose.ymldocker/dockerfilesrc/presentation/web/package.jsonturbo.json
💤 Files with no reviewable changes (1)
- docker/docker-compose.yml
| "lint": "prettier --check . && eslint .", | ||
| "format": "prettier --write .", | ||
| "setup": "playwright install --with-deps && npm run build-storybook", | ||
| "setup": "PLAYWRIGHT_BROWSERS_PATH=../../../.cache/ms-playwright playwright install --with-deps && npm run build-storybook", |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Use Bun for the follow-up script invocation.
This script still shells out to npm run build-storybook, which breaks the repo-wide package-manager contract. Switch it to bun run build-storybook so setup stays on the same toolchain.
Suggested change
- "setup": "PLAYWRIGHT_BROWSERS_PATH=../../../.cache/ms-playwright playwright install --with-deps && npm run build-storybook",
+ "setup": "PLAYWRIGHT_BROWSERS_PATH=../../../.cache/ms-playwright playwright install --with-deps && bun run build-storybook",As per coding guidelines, "Use Bun as the runtime and package manager for all development tasks".
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "setup": "PLAYWRIGHT_BROWSERS_PATH=../../../.cache/ms-playwright playwright install --with-deps && npm run build-storybook", | |
| "setup": "PLAYWRIGHT_BROWSERS_PATH=../../../.cache/ms-playwright playwright install --with-deps && bun run build-storybook", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/presentation/web/package.json` at line 15, The setup script in
package.json still invokes npm for the follow-up Storybook build, which violates
the Bun-only toolchain contract. Update the setup command to call bun run
build-storybook instead of npm run build-storybook, keeping the existing
Playwright install step intact and preserving the current script name.
Source: Coding guidelines
|
Preview deployed to: https://ThunLights.github.io/distopia/storybook/pr-preview-96 |
|
Preview deployed to: https://ThunLights.github.io/distopia/storybook/pr-preview-96 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/presentation/web/package.json`:
- Line 15: The Playwright setup script in package.json no longer matches the
cached browser location used by the workflow. Update the setup command or the
Playwright browser path configuration so that the browser install uses
.cache/ms-playwright again, or adjust the caching logic to the default
Playwright directory; make sure the change is reflected in the setup script and
any related Playwright configuration symbols.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 6bbe35d3-94ad-4d92-be30-504827166df7
📒 Files selected for processing (1)
src/presentation/web/package.json
|
Preview deployed to: https://ThunLights.github.io/distopia/storybook/pr-preview-96 |
|
Preview deployed to: https://ThunLights.github.io/distopia/storybook/pr-preview-96 |
…ependencies in Turbo configuration
…Docker configurations
|
Preview deployed to: https://ThunLights.github.io/distopia/storybook/pr-preview-96 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/presentation/web/playwright.config.ts`:
- Line 9: The Playwright preview command in the config is using npm directly and
skips the required build step, which can fail on a clean run. Update the preview
setup in the playwright config so it follows the repo’s Bun script convention
and runs the build before starting preview, ensuring the existing dist output is
created first. Use the preview command entry in the Playwright config to make
this change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a037aea3-e64f-4136-a4b6-a4f51bbb18e0
📒 Files selected for processing (4)
docker/docker-compose.dev.ymldocker/docker-compose.ymlsrc/presentation/web/playwright.config.tsturbo.json
💤 Files with no reviewable changes (1)
- docker/docker-compose.yml
🚧 Files skipped from review as they are similar to previous changes (1)
- turbo.json
| }, | ||
| webServer: { | ||
| command: "npm run build && npm run preview", | ||
| command: "npm run preview", |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n== playwright.config.ts ==\n'
cat -n src/presentation/web/playwright.config.ts | sed -n '1,120p'
printf '\n== package.json ==\n'
cat -n src/presentation/web/package.json | sed -n '1,120p'
printf '\n== search for webServer command / preview usage ==\n'
rg -n '"npm run preview"|"bun run preview"|"vite preview"|"build && preview"|"playwright' src/presentation/web -SRepository: ThunLights/distopia
Length of output: 4640
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n== root package/workflow references ==\n'
rg -n '"test:e2e"|"playwright test"|"vite build"|"bun run build"|"npm run build"|"npm run preview"|"bun run preview"|"playwright install"|"preview"' \
. \
-g '!**/node_modules/**' \
-g '!**/dist/**' \
-g '!**/.git/**' \
-S
printf '\n== files mentioning playwright.config.ts or webServer ==\n'
rg -n 'webServer|playwright.config.ts|reuseExistingServer|baseURL' src .github . -g '!**/node_modules/**' -SRepository: ThunLights/distopia
Length of output: 1119
Restore the build step before preview. vite preview expects an existing dist, so npm run preview can fail on a clean Playwright run and bypasses the repo’s Bun-only script convention.
Suggested change
- command: "npm run preview",
+ command: "bun run build && bun run preview",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| command: "npm run preview", | |
| command: "bun run build && bun run preview", |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/presentation/web/playwright.config.ts` at line 9, The Playwright preview
command in the config is using npm directly and skips the required build step,
which can fail on a clean run. Update the preview setup in the playwright config
so it follows the repo’s Bun script convention and runs the build before
starting preview, ensuring the existing dist output is created first. Use the
preview command entry in the Playwright config to make this change.
Source: Coding guidelines
1 participant
Summary by CodeRabbit