Skip to content

fix: cache in github actions #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ro80t merged 13 commits into from
Jun 29, 2026
+15 −8
Merged

fix: cache in github actions #96

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4cd50db
fix: add caching step to improve build performance
ro80t Jun 28, 2026
37a33a7
fix: update setup script to specify playwright browsers path
ro80t Jun 28, 2026
81dda27
fix: correct user group ID check in Dockerfile
ro80t Jun 28, 2026
08ef7f3
fix: remove unused cache volume from docker-compose.yml
ro80t Jun 28, 2026
73e0eab
fix: refine caching steps for Bun install and Playwright browsers
ro80t Jun 28, 2026
f74225e
fix: add caching for Turbo build process
ro80t Jun 28, 2026
c844ade
fix: update Bun install cache key and restore keys
ro80t Jun 28, 2026
f34963b
fix: update Playwright test command to include browser path
ro80t Jun 28, 2026
a99a75b
fix: simplify Playwright setup and test commands
ro80t Jun 29, 2026
aaeab09
fix: remove cacheDir from Turbo configuration
ro80t Jun 29, 2026
ae17db4
fix: add caching option to setup task in Turbo configuration
ro80t Jun 29, 2026
5cefbbc
fix: update web server command in Playwright config and adjust task d…
ro80t Jun 29, 2026
51580e9
fix: synchronize command settings between development and production …
ro80t Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,30 @@ runs:
cache-from: type=gha
cache-to: type=gha,mode=max

- name: Cache Bun install
uses: actions/cache@v6
with:
path: .cache/bun/install
key: ${{ runner.os }}-bun-install-${{ hashFiles('**/bun.lock') }}
restore-keys: |
${{ runner.os }}-bun-install-

- name: Cache Playwright browsers
uses: actions/cache@v6
with:
path: .cache/ms-playwright
key: ${{ runner.os }}-playwright-${{ hashFiles('src/presentation/web/package.json') }}
restore-keys: |
${{ runner.os }}-playwright-

- name: Cache Turbo
uses: actions/cache@v6
with:
path: .cache/turbo
key: ${{ runner.os }}-turbo-${{ github.sha }}
restore-keys: |
${{ runner.os }}-turbo-

- name: Checkout Container
working-directory: ./docker/
shell: bash
Expand Down
2 changes: 0 additions & 2 deletions docker/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,11 @@ services:
command: sleep infinity
volumes:
- ..:/workspaces/distopia:cached
- distopia-cache:/workspaces/distopia/.cache
- distopia-node-modules:/workspaces/distopia/node_modules

volumes:
distopia-db-store:
external: true
distopia-cache:
distopia-node-modules:

networks:
Expand Down
2 changes: 1 addition & 1 deletion docker/dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ RUN apt-get update \
&& rm -rf /var/lib/apt/lists/*

RUN [[ $(id -u ubuntu) = $USER_UID ]] || usermod -u $USER_UID ubuntu \
&& [[ $(id -u ubuntu) = $USER_GID ]] || groupmod -g $USER_GID ubuntu \
&& [[ $(id -g ubuntu) = $USER_GID ]] || groupmod -g $USER_GID ubuntu \
&& echo "ubuntu ALL=NOPASSWD: ALL" > /etc/sudoers.d/ubuntu \
&& chmod 0440 /etc/sudoers.d/ubuntu

Expand Down
2 changes: 1 addition & 1 deletion src/presentation/web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch",
"lint": "prettier --check . && eslint .",
"format": "prettier --write .",
"setup": "playwright install --with-deps && npm run build-storybook",
"setup": "PLAYWRIGHT_BROWSERS_PATH=../../../.cache/ms-playwright playwright install --with-deps && npm run build-storybook",

@coderabbitai coderabbitai Bot Jun 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Use Bun for the follow-up script invocation.

This script still shells out to npm run build-storybook, which breaks the repo-wide package-manager contract. Switch it to bun run build-storybook so setup stays on the same toolchain.

Suggested change 
-    "setup": "PLAYWRIGHT_BROWSERS_PATH=../../../.cache/ms-playwright playwright install --with-deps && npm run build-storybook",
+    "setup": "PLAYWRIGHT_BROWSERS_PATH=../../../.cache/ms-playwright playwright install --with-deps && bun run build-storybook",

As per coding guidelines, "Use Bun as the runtime and package manager for all development tasks".

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"setup": "PLAYWRIGHT_BROWSERS_PATH=../../../.cache/ms-playwright playwright install --with-deps && npm run build-storybook",
"setup": "PLAYWRIGHT_BROWSERS_PATH=../../../.cache/ms-playwright playwright install --with-deps && bun run build-storybook",
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/presentation/web/package.json` at line 15, The setup script in
package.json still invokes npm for the follow-up Storybook build, which violates
the Bun-only toolchain contract. Update the setup command to call bun run
build-storybook instead of npm run build-storybook, keeping the existing
Playwright install step intact and preserving the current script name.

Source: Coding guidelines

"test:unit": "vitest",
"test": "npm run test:unit -- --run && npm run test:e2e",
"test:e2e": "playwright test",
Expand Down
1 change: 1 addition & 0 deletions turbo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"$schema": "./node_modules/turbo/schema.json",
"cacheDir": ".cache/turbo",
"tasks": {
"build": {
"dependsOn": ["^build"],
Expand Down
Loading