Merge duplicate operating rules by combining calendars#49
Merged
Conversation
Rules sharing the same (from_zone, to_zone, time_windows, route, vehicle_type) now merge their calendars lists instead of creating separate entries per trip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Operating rules that share the same identity (from_zone, to_zone, time windows, route, vehicle type) but differ only in calendar are now merged into a single rule with a combined calendars list.
Previously,
add_zone_to_zone_rulecreated a newOperationRuleper trip, each with a single-elementcalendarslist. For feeds with many trips across the same zone pairs (e.g. different days of the week), this produced massive duplication — one real-world feed went from 1608 rules down to 132 after this change.This should fix a crash on LINEADFR_F on Dreux in bpinCompression which overflow int_max. Context : https://transit.slack.com/archives/C01K58SPPQ8/p1777906113949719