Skip to content

Merge duplicate operating rules by combining calendars #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcamp merged 2 commits into from
May 6, 2026
Merged

Merge duplicate operating rules by combining calendars #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb7599e
Merge duplicate operating rules by combining calendars
gcamp May 6, 2026
7e4aecb
Simplify: extract vehicle type constant, use set for calendar accumul…
gcamp May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 23 additions & 16 deletions gtfs_flex_to_gofs/files/operation_rules.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from enum import Enum

FILENAME = 'operating_rules'
DEFAULT_VEHICLE_TYPE = 'large_van'

class TripType(Enum):
REGULAR_SERVICE = "regular_service"
Expand All @@ -30,7 +31,7 @@ class OperationRule:

def create(gtfs, itineraries=False):
gofs_feed = GofsData()
operating_rules = []
rules_by_key = {}

for trip in gtfs.trips.values():
stop_times = gtfs.itinerary_cells[trip.itinerary_index] if itineraries else gtfs.stop_times[trip.trip_id]
Expand All @@ -57,10 +58,13 @@ def create(gtfs, itineraries=False):
to_is_valid = stop_time.start_pickup_drop_off_window != -1 and stop_time.end_pickup_drop_off_window != -1

if from_is_valid and to_is_valid:
add_zone_to_zone_rule(prev_stop_time, prev_stop_time.stop_id, stop_time.stop_id, trip, operating_rules, gofs_feed)
add_zone_to_zone_rule(prev_stop_time, prev_stop_time.stop_id, stop_time.stop_id, trip, rules_by_key, gofs_feed)
register_data(GofsTransfer(trip.trip_id, prev_stop_time.stop_id, stop_time.stop_id), trip, prev_stop_time.pickup_booking_rule_id, gofs_feed)



operating_rules = list(rules_by_key.values())
for rule in operating_rules:
rule.calendars = sorted(rule.calendars)
operating_rules.sort(key=lambda x: (x.from_zone_id, x.to_zone_id, x.brand_id, x.vehicle_type_id, x.start_pickup_window, x.end_pickup_window, x.end_dropoff_window, x.calendars))

return GofsFile(FILENAME, created=True, data=operating_rules), gofs_feed
Expand Down Expand Up @@ -114,19 +118,22 @@ def register_data(transfer: GofsTransfer, trip, pickup_booking_rule_id, gofs_fee
gofs_feed.register_pickup_booking_rule_id(pickup_booking_rule_id, transfer)


def add_zone_to_zone_rule(prev_stop_time, from_stop_id, to_stop_id, trip, operating_rules, gofs_feed):
def add_zone_to_zone_rule(prev_stop_time, from_stop_id, to_stop_id, trip, rules_by_key, gofs_feed):
gofs_feed.register_zone_id(from_stop_id)
gofs_feed.register_zone_id(to_stop_id)

operating_rule = OperationRule(
from_zone_id=from_stop_id,
to_zone_id=to_stop_id,
start_pickup_window=prev_stop_time.start_pickup_drop_off_window,
end_pickup_window=prev_stop_time.end_pickup_drop_off_window,
end_dropoff_window=-1,
calendars=[trip.service_id],
brand_id=trip.route_id,
vehicle_type_id='large_van'
)

operating_rules.append(operating_rule)
key = (from_stop_id, to_stop_id, prev_stop_time.start_pickup_drop_off_window, prev_stop_time.end_pickup_drop_off_window, trip.route_id, DEFAULT_VEHICLE_TYPE)

if key in rules_by_key:
rules_by_key[key].calendars.add(trip.service_id)
else:
rules_by_key[key] = OperationRule(
from_zone_id=from_stop_id,
to_zone_id=to_stop_id,
start_pickup_window=prev_stop_time.start_pickup_drop_off_window,
end_pickup_window=prev_stop_time.end_pickup_drop_off_window,
end_dropoff_window=-1,
calendars={trip.service_id},
brand_id=trip.route_id,
vehicle_type_id=DEFAULT_VEHICLE_TYPE
)
Loading
Loading