Fix Unreal 5.4 Linux Compile Errors #293
Open
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayhf
commented
Jan 7, 2025
| @@ -768,11 +768,11 @@ namespace RealtimeMesh | |||
| if (const auto ThisShared = ThisWeak.Pin()) | |||
| { | |||
| FRealtimeMeshAccessContext AccessContext(ThisShared.ToSharedRef()); | |||
| FRealtimeMeshComplexGeometry ComplexGeometry; | |||
There was a problem hiding this comment.
Shadowed another variable of the same name
| @@ -348,7 +348,7 @@ namespace RealtimeMesh | |||
|
|
|||
| virtual void ProcessEndOfFrameUpdates() override; | |||
|
|
|||
| friend class URealtimeMeshSimple; | |||
| friend class ::URealtimeMeshSimple; | |||
There was a problem hiding this comment.
Explicit namespace is necessary to prevent this from being treated as a different type
There was a problem hiding this comment.
Also fixed in https://github.com/TriAxis-Games/RealtimeMeshComponent/pull/292/files, but I think it's better to fix the friend declaration
| @@ -214,7 +214,7 @@ namespace RealtimeMesh | |||
| #endif | |||
| } | |||
|
|
|||
| /*Batcher.QueueUpdateRequest(VertexBufferRHI, UpdateData->GetNumElements() > 0? UpdateData->GetBuffer() : nullptr); | |||
There was a problem hiding this comment.
Starting a block comment is not allowed in a block comment
There was a problem hiding this comment.
Similar change in https://github.com/TriAxis-Games/RealtimeMeshComponent/pull/292/files
| @@ -6,6 +6,7 @@ | |||
| #include "ComponentAssetBroker.h" | |||
| #include "EngineUtils.h" | |||
| #include "IAssetTools.h" | |||
| #include "Editor.h" | |||
There was a problem hiding this comment.
Missing include, as reported here: #286 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several compiler errors (and warnings treated as errors) I encountered when using Unreal 5.4 on Linux