Fix ghost migrate lowercasing files #1391
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures file references in posts continue pointing to valid filenames.
Seeing as we no longer convert filenames to lowercase when downloading from the server, our tests should expect the original filenames in their original case.
…host-lowercase-files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using
migrate ghost...to migrate a ghost instance from one install to another. I found the files downloaded had their filenames all lowercased, but the post and page import expected the original filenames. This resulted in most images, videos, and files embeded within posts and pages broken (missing).I've made a small adjustment to mg-fs-utils to prevent the lowercasing of filenames, and updated the tests to expect the same filenames which are on the respective servers.