Skip to content

Fix ghost migrate lowercasing files #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jyergatian wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix ghost migrate lowercasing files #1391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f88e2f
prevent modification for filenames
jyergatian Jul 25, 2025
d2d6dc3
updated tests to expect same names as server
jyergatian Jul 25, 2025
2719185
Merge branch 'main' of https://github.com/TryGhost/migrate into fix-g…
jyergatian Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/mg-assetscraper-db/src/test/AssetScraper.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ describe('Asset Scraper', () => {

const result = await assetScraper.resolveFileName('https://example.com/path/to/你好.jpg', 'images');

assert.equal(result.filename, 'example-com/path/to/ni_hao.jpg');
assert.equal(result.filename, 'example-com/path/to/Ni_Hao.jpg');
});

it.todo('test replaceSrc else');
Expand Down
3 changes: 2 additions & 1 deletion packages/mg-fs-utils/lib/FileCache.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ export default class FileCache {
let fileNameExt = extname(src);

let safeFileNameNoExt = transliterate.slugify(fileNameNoExt, {
separator: '_'
separator: '_',
lowercase: false
});

let result = src.replace(`${fileNameNoExt}${fileNameExt}`, `${safeFileNameNoExt}${fileNameExt}`);
Expand Down
20 changes: 10 additions & 10 deletions packages/mg-fs-utils/test/file-cache.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ describe('resolveFileName character handling', function () {

let fileName = await fileCache.resolveFileName('/image/fetch/w_600%2Ch_400,c_fill,f_auto,q_auto:good,fl_progressive:steep,g_center/https%3A%2F%2Fsubstack-post-media.s3.amazonaws.com%2Fpublic%2Fimages%2Fad8015f6-a9.0c-46f8-89f2-b6d7db866c6e_3866x2298.jpeg');

expect(fileName.filename).toEqual('/image/fetch/w_600-h_400-c_fill-f_auto-q_auto:good-fl_progressive:steep-g_center/https_3a_2f_2fsubstack-post-media-s3-amazonaws-com_2fpublic_2fimages_2fad8015f6-a9-0c-46f8-89f2-b6d7db866c6e_3866x2298.jpg');
expect(fileName.filename).toEqual('/image/fetch/w_600-h_400-c_fill-f_auto-q_auto:good-fl_progressive:steep-g_center/https_3A_2F_2Fsubstack-post-media-s3-amazonaws-com_2Fpublic_2Fimages_2Fad8015f6-a9-0c-46f8-89f2-b6d7db866c6e_3866x2298.jpg');

await fileCache.emptyCurrentCacheDir();
});
Expand Down Expand Up @@ -288,9 +288,9 @@ describe('resolveFileName character handling', function () {
let fileCache = new FileCache('test');
let fileName = await fileCache.resolveFileName('/my-images/快乐的小树.jpeg');

expect(fileName.filename).toEqual('/my-images/kuai_le_de_xiao_shu.jpg');
expect(fileName.storagePath).toInclude('/content/images/my-images/kuai_le_de_xiao_shu.jpg');
expect(fileName.outputPath).toEqual('/content/images/my-images/kuai_le_de_xiao_shu.jpg');
expect(fileName.filename).toEqual('/my-images/Kuai_Le_De_Xiao_Shu.jpg');
expect(fileName.storagePath).toInclude('/content/images/my-images/Kuai_Le_De_Xiao_Shu.jpg');
expect(fileName.outputPath).toEqual('/content/images/my-images/Kuai_Le_De_Xiao_Shu.jpg');

await fileCache.emptyCurrentCacheDir();
});
Expand All @@ -299,9 +299,9 @@ describe('resolveFileName character handling', function () {
let fileCache = new FileCache('test');
let fileName = await fileCache.resolveFileName('/my-images/幸せな小さな木.jpeg');

expect(fileName.filename).toEqual('/my-images/xing_senaxiao_sanamu.jpg');
expect(fileName.storagePath).toInclude('/content/images/my-images/xing_senaxiao_sanamu.jpg');
expect(fileName.outputPath).toEqual('/content/images/my-images/xing_senaxiao_sanamu.jpg');
expect(fileName.filename).toEqual('/my-images/Xing_senaXiao_sanaMu.jpg');
expect(fileName.storagePath).toInclude('/content/images/my-images/Xing_senaXiao_sanaMu.jpg');
expect(fileName.outputPath).toEqual('/content/images/my-images/Xing_senaXiao_sanaMu.jpg');

await fileCache.emptyCurrentCacheDir();
});
Expand All @@ -310,9 +310,9 @@ describe('resolveFileName character handling', function () {
let fileCache = new FileCache('test');
let fileName = await fileCache.resolveFileName('/my-images/أشجار صغيرة سعيدة.jpeg');

expect(fileName.filename).toEqual('/my-images/shjr-sgyr_-saayd.jpg');
expect(fileName.storagePath).toInclude('/content/images/my-images/shjr-sgyr_-saayd.jpg');
expect(fileName.outputPath).toEqual('/content/images/my-images/shjr-sgyr_-saayd.jpg');
expect(fileName.filename).toEqual('/my-images/shjr-SGyr_-saayd.jpg');
expect(fileName.storagePath).toInclude('/content/images/my-images/shjr-SGyr_-saayd.jpg');
expect(fileName.outputPath).toEqual('/content/images/my-images/shjr-SGyr_-saayd.jpg');

await fileCache.emptyCurrentCacheDir();
});
Expand Down