Skip to content

HPC-10152: fix PostgreSQL query params limit #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2025
Merged

HPC-10152: fix PostgreSQL query params limit #352

merged 2 commits into from
May 27, 2025

Conversation

manelcecs
Copy link
Contributor

@manelcecs manelcecs commented Apr 2, 2025 •
edited
Loading

This PR fixes the main issue when performing queries with where clauses with hundreds of thousand of elements.

This PR needs to be merged first: #351

@manelcecs manelcecs added the ready for review All comments have been addressed, and the Pull Request is ready for review label Apr 2, 2025
@manelcecs manelcecs requested a review from a team as a code owner April 2, 2025 16:20
unocha-hpc
unocha-hpc approved these changes Apr 2, 2025
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@manelcecs manelcecs added the pending prior merge Another Pull Request needs to be merged before this one label Apr 3, 2025
@Delgee Delgee assigned manelcecs and unassigned Delgee Apr 4, 2025
@Delgee Delgee removed the ready for review All comments have been addressed, and the Pull Request is ready for review label Apr 4, 2025
Pl217
Pl217 requested changes Apr 4, 2025
View reviewed changes
@Pl217
Copy link
Contributor

Pl217 commented Apr 4, 2025

Note, I haven't reviewed this, I was just intrigued by the title.

@manelcecs manelcecs changed the title HPC-10152: fix memory leak HPC-10152: fix PostgreSQL query params limit Apr 7, 2025
unocha-hpc
unocha-hpc approved these changes Apr 7, 2025
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@manelcecs manelcecs assigned Delgee and unassigned manelcecs Apr 7, 2025
@manelcecs manelcecs added the ready for review All comments have been addressed, and the Pull Request is ready for review label Apr 7, 2025
@manelcecs
Copy link
Contributor Author

I've dropped the commit with the increase of the performance since I believe this is not the place to do it - I'll create a different PR for that in the close future!

Base automatically changed from HPC-10150 to develop April 7, 2025 09:36
@Delgee Delgee removed the ready for review All comments have been addressed, and the Pull Request is ready for review label Apr 7, 2025
@Delgee Delgee assigned manelcecs and unassigned Delgee Apr 7, 2025
unocha-hpc
unocha-hpc approved these changes Apr 7, 2025
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Apr 15, 2025
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Apr 22, 2025
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes Apr 22, 2025
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@manelcecs manelcecs added ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished. and removed pending prior merge Another Pull Request needs to be merged before this one labels Apr 22, 2025
@manelcecs manelcecs assigned Pl217 and unassigned manelcecs Apr 22, 2025
@manelcecs manelcecs added ready for review All comments have been addressed, and the Pull Request is ready for review and removed ready for merge Review and testing is complete. It is ready for merging as soon as CI has finished. labels Apr 22, 2025
unocha-hpc
unocha-hpc approved these changes May 13, 2025
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

unocha-hpc
unocha-hpc approved these changes May 14, 2025
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

Pl217
Pl217 requested changes May 21, 2025
View reviewed changes
@Pl217 Pl217 assigned manelcecs and unassigned Pl217 May 21, 2025
@Pl217 Pl217 added needs minor changes There are review or issue comments to address and removed ready for review All comments have been addressed, and the Pull Request is ready for review labels May 21, 2025
unocha-hpc
unocha-hpc approved these changes May 27, 2025
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@manelcecs manelcecs assigned Pl217 and unassigned manelcecs May 27, 2025
@manelcecs manelcecs added ready for review All comments have been addressed, and the Pull Request is ready for review and removed needs minor changes There are review or issue comments to address labels May 27, 2025
Pl217
Pl217 approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@Pl217 Pl217 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thing which I'll fix myself and then merge this.

unocha-hpc
unocha-hpc approved these changes May 27, 2025
View reviewed changes
Copy link

@unocha-hpc unocha-hpc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks have passed and this pull request is ready for manual review

@Pl217 Pl217 merged commit e170a03 into develop May 27, 2025
5 checks passed
@Pl217 Pl217 deleted the HPC-10152 branch May 27, 2025 15:46
@Pl217 Pl217 mentioned this pull request Jun 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pl217 Pl217 Pl217 approved these changes

@unocha-hpc unocha-hpc unocha-hpc approved these changes

+1 more reviewer

@Delgee Delgee Delgee approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Pl217 Pl217

Labels
ready for review All comments have been addressed, and the Pull Request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@manelcecs @Pl217 @Delgee @unocha-hpc