This repository was archived by the owner on Sep 21, 2025. It is now read-only.
Tanmay Shah #114
Open
Tanmay Shah #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxlou05
reviewed
Oct 8, 2024
| if report.status == drone_status.DroneStatus.HALTED: | ||
| # check if at the waypoint | ||
| if not self.has_reached_waypoint and distance_net_squared <= self.acceptance_radius**2: | ||
| command = commands.Command.create_land_command() |
Member
There was a problem hiding this comment.
You don't need to land at the waypoint, just get there and then go towards the landing pad (you land at the landing pad)
| command = commands.Command.create_set_relative_destination_command( | ||
| diff_distance_x, diff_distance_y | ||
| ) | ||
| print("Moving to closest landing pad!") |
Member
There was a problem hiding this comment.
There doesn't seem to be an implementation for actually reaching and landing on the landing pad, this just gets the drone to move towards the closest landing pad
| for i in range(0, boxes_cpu.shape[0]): | ||
| # Create BoundingBox object and append to list | ||
| result, box = bounding_box.BoundingBox.create(boxes_cpu[i]) | ||
| if result: # this way only valid boxes are added |
Member
There was a problem hiding this comment.
Normally in statistics, we discard the whole datapoint (the entire image) if a part of it goes wrong (one bounding box).
You do not need to change anything here, just something to think about.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.