This repository was archived by the owner on Sep 13, 2023. It is now read-only.
This is a pull request for Autonomy Bootcamp [OLD] by Vibhinn Gautam #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgupta27
reviewed
Sep 13, 2023
| """ | ||
| transform = transforms.Compose( | ||
| [transforms.ToTensor(), transforms.Normalize((0.5, 0.5, 0.5), (0.5, 0.5, 0.5)) | ||
| ]) |
There was a problem hiding this comment.
Nit: Keep ending square bracket in line 14 and remove tab from line 15. Take a look at our Python Style Guide in Confluence for more info on our style. (You do not need to change anything here, just smth to think about).
mgupta27
reviewed
Sep 13, 2023
|
|
||
| # Import whatever libraries/modules you need | ||
| # this is our test set | ||
| test = torchvision.datasets.CIFAR10(root='./data', train=False, |
There was a problem hiding this comment.
Nit: Try using a better variable name. For example test_dataset. (You don't need to fix anything here, just smth to think about).
mgupta27
reviewed
Sep 13, 2023
mgupta27
left a comment
mgupta27
left a comment
There was a problem hiding this comment.
LGTM!
Logic looks good to me. Just some things to look out for is code style and coming up with better names for variables and classes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.