This repository was archived by the owner on Nov 13, 2025. It is now read-only.
Restart worker patch with fixed commit history #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HermanG05
approved these changes
Jan 22, 2025
Contributor
HermanG05
left a comment
HermanG05
left a comment
There was a problem hiding this comment.
Conditionally Approved. Just address the two comments and push your changes before merging.
| if is_invalid: | ||
| continue | ||
|
|
||
| result, value = comm.run(input_queue.queue.get()) |
Contributor
There was a problem hiding this comment.
Replace the argument with input_data
| import queue | ||
|
|
||
| from modules import object_in_world | ||
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new PR for the restart workers that fixes the messy commit history and implements some new changes.
Some things to note: