-
Notifications
You must be signed in to change notification settings - Fork 37
Add timing logs to workers #249
Conversation
achitaan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small changes
| output_queue is the data queue. | ||
| controller is how the main process communicates to this worker process. | ||
| """ | ||
| start_time = time.time() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be more specific with the naming (for the end_time too)
use something along the lines of:
constructor_start_time
| local_logger.info(f"{time.time()}: Class object creation took {end_time - start_time} seconds.") | ||
|
|
||
| while not controller.is_exit_requested(): | ||
| start_time = time.time() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be more specific with the naming (for the end_time too)
use something along the lines of:
iterator_start_time
| worker_controller: worker_controller.WorkerController | ||
| How the main process communicates to this worker process. | ||
| """ | ||
| start_time = time.time() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be more specific with the naming for each timings (more specific detail in video_input_worker)
| input_queue and output_queue are data queues. | ||
| controller is how the main process communicates to this worker process. | ||
| """ | ||
| start_time = time.time() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be more specific with the naming for each timings (more specific detail in video_input_worker)
| Merge work is done in the worker process as the queues and control mechanisms | ||
| are naturally available. | ||
| """ | ||
| start_time = time.time() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be more specific with the naming for each timings (more specific detail in video_input_worker)
| input_queue and output_queue are data queues. | ||
| controller is how the main process communicates to this worker process. | ||
| """ | ||
| start_time = time.time() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be more specific with the naming for each timings (more specific detail in video_input_worker)
| controller is how the main process communicates to this worker process. | ||
| """ | ||
| # TODO: Error handling | ||
| start_time = time.time() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be more specific with the naming for each timings (more specific detail in video_input_worker)
| controller is how the main process communicates to this worker process. | ||
| """ | ||
| # TODO: Handle errors better | ||
| start_time = time.time() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be more specific with the naming for each timings (more specific detail in video_input_worker)
No description provided.