Skip to content
This repository was archived by the owner on Nov 13, 2025. It is now read-only.

Conversation

@siddhp1
Copy link
Contributor

@siddhp1 siddhp1 commented Feb 3, 2025

No description provided.

Copy link

@achitaan achitaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small changes

output_queue is the data queue.
controller is how the main process communicates to this worker process.
"""
start_time = time.time()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be more specific with the naming (for the end_time too)

use something along the lines of:
constructor_start_time

local_logger.info(f"{time.time()}: Class object creation took {end_time - start_time} seconds.")

while not controller.is_exit_requested():
start_time = time.time()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be more specific with the naming (for the end_time too)

use something along the lines of:
iterator_start_time

worker_controller: worker_controller.WorkerController
How the main process communicates to this worker process.
"""
start_time = time.time()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be more specific with the naming for each timings (more specific detail in video_input_worker)

input_queue and output_queue are data queues.
controller is how the main process communicates to this worker process.
"""
start_time = time.time()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be more specific with the naming for each timings (more specific detail in video_input_worker)

Merge work is done in the worker process as the queues and control mechanisms
are naturally available.
"""
start_time = time.time()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be more specific with the naming for each timings (more specific detail in video_input_worker)

input_queue and output_queue are data queues.
controller is how the main process communicates to this worker process.
"""
start_time = time.time()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be more specific with the naming for each timings (more specific detail in video_input_worker)

controller is how the main process communicates to this worker process.
"""
# TODO: Error handling
start_time = time.time()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be more specific with the naming for each timings (more specific detail in video_input_worker)

controller is how the main process communicates to this worker process.
"""
# TODO: Handle errors better
start_time = time.time()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be more specific with the naming for each timings (more specific detail in video_input_worker)

@siddhp1 siddhp1 merged commit 74e934e into main Mar 18, 2025
1 check passed
@siddhp1 siddhp1 deleted the profile-performance branch March 18, 2025 02:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants