This repository was archived by the owner on Nov 13, 2025. It is now read-only.
Cluster estimation filter #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxlou05
reviewed
Feb 14, 2025
| MAX_NUM_COMPONENTS, | ||
| RNG_SEED, | ||
| test_logger, | ||
| MIN_POINTS_PER_CLUSTER, |
Member
There was a problem hiding this comment.
Did you verify the test cases to make sure that all the clusters have at least 3 points? Can you also make a test where there is a cluster that only has like 1 point (ie make a very far outlier)
Member
There was a problem hiding this comment.
Also, did you check the integration tests? They are under tests/integration
ellyokes253
pushed a commit
that referenced
this pull request
Apr 3, 2025
* min_points_per_cluster * config * format * fix * format * update * update * 'format' * 'format' * 'update' * debug * integration * format * main_edit
ellyokes253
pushed a commit
that referenced
this pull request
Apr 10, 2025
interactive rebase in progress; onto 4c1f188 Last commands done (3 commands done): pick 9a1644c Fix parameter ordering issue for workers (#259) pick 3d70054 config.yaml brightspot changes, test brightspot address changes Next commands to do (2 remaining commands): pick 2aa3d90 config.yaml brightspot changes, test brightspot address changes pick 0160310 Cluster estimation filter (#253) You are currently rebasing branch 'houston-testing' on '4c1f188'. Changes to be committed: modified: modules/common Changes not staged for commit: modified: modules/common (modified content)
ellyokes253
pushed a commit
that referenced
this pull request
Apr 10, 2025
* min_points_per_cluster * config * format * fix * format * update * update * 'format' * 'format' * 'update' * debug * integration * format * main_edit
ellyokes253
pushed a commit
that referenced
this pull request
Apr 16, 2025
* min_points_per_cluster * config * format * fix * format * update * update * 'format' * 'format' * 'update' * debug * integration * format * main_edit
ellyokes253
pushed a commit
that referenced
this pull request
Apr 16, 2025
interactive rebase in progress; onto 4c1f188 Last commands done (3 commands done): pick 9a1644c Fix parameter ordering issue for workers (#259) pick 3d70054 config.yaml brightspot changes, test brightspot address changes Next commands to do (2 remaining commands): pick 2aa3d90 config.yaml brightspot changes, test brightspot address changes pick 0160310 Cluster estimation filter (#253) You are currently rebasing branch 'houston-testing' on '4c1f188'. Changes to be committed: modified: modules/common Changes not staged for commit: modified: modules/common (modified content)
ellyokes253
pushed a commit
that referenced
this pull request
Apr 16, 2025
* min_points_per_cluster * config * format * fix * format * update * update * 'format' * 'format' * 'update' * debug * integration * format * main_edit
ellyokes253
pushed a commit
that referenced
this pull request
Apr 29, 2025
* min_points_per_cluster * config * format * fix * format * update * update * 'format' * 'format' * 'update' * debug * integration * format * main_edit
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.