-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Cura 12701 user estimation factor #20928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HellAholic
wants to merge
11
commits into
main
Choose a base branch
from
CURA-12701_user_estimation_factor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting is only front-end side and does not affect slicing.
Contributor
default to None for user time estimation factor
Member
|
I think I'd personally just set it up per-printer in the settings, that way, we can communicate it to the engine & that can use the 'proper' time-estimates, which would then also work with c. cloud. |
Collaborator
|
Looks like the field is in the wrong column; I don't think this has anything to do with the printhead (right column) and should instead be in the left column (printer) |
Setting type is float, so the min/maximum_value should also have a float value rather than a string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
PR: Community Contribution 👑
Community Contribution PR's
PR: Improving UI 🎨
Like better navigation arrows, fixing scroll bar bugs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is purely visual and will not affect the print time data inside the gcode.
Adds a field to the machine settings page of the printer to allow the users to adjust the print estimation shown after the slice.

The field takes a float value between 1 to 1000 calculated as a percentage with default value of 100
The factor is applied to all the different print time values returned from the engine
The behavior is unchanged if the factor is at default value of 100 - no adjustments made
Ensures the new slice time estimate message does not collide with other UI elements if the message is too long

Type of change
How Has This Been Tested?
Test Configuration:
Checklist: