Skip to content

Conversation

@HellAholic
Copy link
Contributor

@HellAholic HellAholic commented Sep 6, 2025

Description

This change is purely visual and will not affect the print time data inside the gcode.

Adds a field to the machine settings page of the printer to allow the users to adjust the print estimation shown after the slice.
image

The field takes a float value between 1 to 1000 calculated as a percentage with default value of 100
The factor is applied to all the different print time values returned from the engine

image

The behavior is unchanged if the factor is at default value of 100 - no adjustments made

Ensures the new slice time estimate message does not collide with other UI elements if the message is too long
image

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Build on Windows and validate functionality
  • Modify the value and slice -> should show the *User Adjusted
  • Set the value back to 100 -> should show the print estimate unchanged

Test Configuration:

  • Operating System: Windows 11

Checklist:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2025

Test Results

23 981 tests  ±0   23 979 ✅ ±0   47s ⏱️ ±0s
     1 suites ±0        2 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 4a9fcd1. ± Comparison against base commit ede8b7e.

♻️ This comment has been updated with latest results.

@HellAholic HellAholic added PR: Community Contribution 👑 Community Contribution PR's PR: Improving UI 🎨 Like better navigation arrows, fixing scroll bar bugs labels Sep 6, 2025
default to None for user time estimation factor
@HellAholic HellAholic marked this pull request as ready for review September 6, 2025 12:35
@GregValiant GregValiant mentioned this pull request Sep 6, 2025
1 task
@rburema
Copy link
Member

rburema commented Sep 9, 2025

I think I'd personally just set it up per-printer in the settings, that way, we can communicate it to the engine & that can use the 'proper' time-estimates, which would then also work with c. cloud.

@fieldOfView
Copy link
Collaborator

Looks like the field is in the wrong column; I don't think this has anything to do with the printhead (right column) and should instead be in the left column (printer)

HellAholic and others added 3 commits September 9, 2025 12:26
Setting type is float, so the min/maximum_value should also have a float value rather than a string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Community Contribution 👑 Community Contribution PR's PR: Improving UI 🎨 Like better navigation arrows, fixing scroll bar bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants