chore: make it build with strict null checks set to true #9554
+577
−310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
@chriswk, core features have been modified in this pull request. Please review carefully! |
github-actions
bot
requested review from
FredrikOseberg,
gastonfournier and
ivarconr
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
Comment on lines
-1
to
-2
| const joi = require('joi'); | ||
| const { nameType } = require('../routes/util'); |
There was a problem hiding this comment.
There was a problem hiding this comment.
It should be. All require is also gone now.
There was a problem hiding this comment.
I think we still have one in version.ts
chriswk
force-pushed
the
fix/strictNullChecks
branch
from
ccc8ab2 to
81aeb10
Compare
chriswk
force-pushed
the
fix/strictNullChecks
branch
from
81aeb10 to
75778dd
Compare
gastonfournier
approved these changes
Mar 19, 2025
| @@ -27,6 +27,7 @@ export default class RemoteAddressStrategy extends Strategy { | |||
| return false; | |||
| } | |||
| } | |||
| return false; | |||
There was a problem hiding this comment.
we didn't have a default response here, I guess some treats void as false.
There was a problem hiding this comment.
Better here would probably have been to drop the isValid check and just try to construct the Address4's so we'd always hit the catch part of the try/catch
There was a problem hiding this comment.
absolutely! Just highlighting a great catch
| const { version } = module.exports; | ||
| export default version; | ||
| module.exports = version; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of preparation for ESM and node/TSC updates, this PR will make Unleash build with strictNullChecks set to true, since that's what's in our tsconfig file. Hence, this PR also removes the
--strictNullChecks falseflag in our compile tasks in package.json.TL;DR - Clean up your code rather than turning off compiler security features :)