Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add layer env var to hide present wait ext #1671

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brain-anti-freeze
Copy link

This adds a workaround for #1592 which removes the VkPhysicalDevicePresentWaitFeaturesKHR extension in the layer if the environment variable GAMESCOPE_WSI_HIDE_PRESENT_WAIT_EXT is set. This resolves the current freezing issue on nVidia in dx12 (without having to set VKD3D_DISABLE_EXTENSIONS), dx11 (without having to patch DXVK not to use the extension) and in native vulkan games.

@matte-schwartz
Copy link

this seems to be working well for me so far, haven't run into any freezing yet.

@tlneondo
Copy link

tlneondo commented Dec 21, 2024

Patched the latest fedora 41 gamescope and it looks like this fixed my issues there as well.

Definitely completely unrelated but now i'm seeing the HDR test patterns in BG3 not showing up when using a controller, probably a BG3 or nvidia bug.

image

@tlneondo
Copy link

Now I have a confirmed issue, trying to use Reshade with the RenoDX addon, which modifies games to output in real HDR (IE not fancy tonemapping) causes crashes for me in both Prey & Metaphor. Getting DXGI_ERROR_DEVICE_RESET errors.

@matte-schwartz
Copy link

@tlneondo Unless it's only an issue introduced with this PR, you should file a new report for that

@mindset-tk
Copy link

This works fantastically. Any chance of it being merged?

@Dannflower
Copy link

I'll preface this by saying it's entirely possible I'm seeing a different issue, but it sure looks the same to me.

I've been experiencing these stuck frames in Overwatch 2 (dx11) on Fedora 41 both when running with and without gamescope. I figured I'd give this patch a shot to see if it was a viable workaround and built the patch into 3.16.1 and verified via the logs that the env var was taking effect.

Unfortunately, I'm continuing to see the stuck frame + audio still playing issue. The only fix is for me to alt + tab or do some other action that causes the game window to come in and out of focus, at which point the rendering resumes as normal. The only thing I've found that seems to help prevent this is having something else running in the background, i.e. a video in a web browser that's forcing the screen to be redrawn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants