-
Notifications
You must be signed in to change notification settings - Fork 40
feat: opentelemetry sdk LoggerProvider #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @blakeroberts-wk , I saw that you've resolve some of the comments, but there are still some that are not resolved but I didn't see any feedback / response. |
After changed the return type to |
Hi @blakeroberts-wk , been a while. Can I know if there are any issues that can be resolved. There are also issues that I need some help :) |
lib/src/sdk/logs/logger.dart
Outdated
body: body, | ||
timeProvider: timeProvider, | ||
); | ||
onLogEmit?.call(log); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, I'm not sure it makes sense to follow either of those implementations. I imagine the designs above are due to legacy reasons or oversight. We should support multiple processors. Those other implementations accomplish this by introducing a MultiLogRecordProcessor
. As far as I can tell, this is superfluous complexity. A logger provider should have a list of processors given to a logger during instantiation. This implementation follows the same lines as other providers (meter and tracer).
https://opentelemetry.io/docs/specs/otel/logs/sdk/#logrecordprocessor
Requesting for review on #207 (comment) |
hi @blakeroberts-wk . Can I get some feedback on #207 (comment) if I got this right? |
acd8b32
to
d4a919f
Compare
d4a919f
to
741ed89
Compare
hi @blakeroberts-wk , can I know if there's any update? Or @evanweible-wf can help on the reviewing process? |
lib/src/sdk/platforms/web/time_providers/web_time_provider.dart
Outdated
Show resolved
Hide resolved
Hi @robbecker-wf . Sorry that I missed your message, I've added the changes from review. |
Hi @blakeroberts-wk , anything else that is pending from me to fix? In case if I missed something out. |
Which problem is this PR solving?
How Has This Been Tested?
Checklist: