Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: opentelemetry sdk LoggerProvider #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: opentelemetry sdk LoggerProvider #207
Changes from all commits
dbda356
630f2cf
7119f8e
6fb8422
69e4e18
79640fb
8ff6c71
d3d98e6
f4b05aa
ff5d1e3
1e050b4
5eed62e
99e374f
38b2137
88eb916
014f087
96938b8
2a9a80a
f0206c6
01636f9
aae1c3e
464a636
2ea0fcf
078bd4a
90ecfdc
4ab30a2
b3f744e
9978329
849e0b0
bebc35e
032fd65
442b466
3fc382e
f0e65ab
b97de95
d9c0429
37fae26
b9598de
741ed89
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this flag? The tracing API is organized similarly and does not need it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these are final, can the getters be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can all of these fields be private?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be cleaner to have two types where one is immutable and the other is mutable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intention of this
makeReadonly
to allow mutation (if any) only duringonLogEmit?.call
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes it sound like that method should take a read/write log and the caller should keep a read-only log afterwards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That method here you are referring to is
onLogEmit
right? It is already takes read/write logfinal Function(sdk.ReadWriteLogRecord)? onLogEmit
since only duringonLogEmit
the logs can be mutate, but not once it's done.