Skip to content

test(coding-agent): restore presentation reset fixtures - #5327

Merged
Yeachan-Heo merged 1 commit into
devfrom
fix/issue-5326-assistant-presentation
Sep 6, 2026
Merged

Yeachan-Heo merged 1 commit into
devfrom
fix/issue-5326-assistant-presentation

Conversation

@Yeachan-Heo

Copy link
Copy Markdown
Owner

What

Restore the required resetAssistantTextPresentation callback in the seven incomplete InteractiveModeContext fixtures implicated by dev CI run 34001273527, and assert reset ownership on transcript rebuild, committed resume, and successful session replacement paths.

Closes #5326.

Why

Production InteractiveMode implements this required callback, and production transcript/session replacement callers invoke it unconditionally. The affected tests cast incomplete fixture objects through unknown, so they failed before exercising their actual lifecycle assertions.

Both exact failing dev ed67422699299b0257dd45ec1d37167b474b4918 and first parent 26ac49874df6001cb57e8a3296a8ddece43c8c8c reproduce 30 missing-method errors across the seven suites. Coding-agent source/tests are identical across that merge, proving PR #5317 exposed rather than introduced the defect.

Overlap was checked before implementation. PR #5323 independently owns resume-session-reentrancy.test.ts; this PR does not touch or duplicate it. PRs #5313, #5283, and #5321 do not repair these seven fixtures.

Distinct run failures in mcp-lifecycle-cleanup.test.ts and gjc-plugin-runtime-adapters.test.ts reproduce independently and remain classified outside #5326.

Testing

Risk classification

  • low-risk — ordinary fix/maintenance; the repository owner may use the explicit merge-self-approved solo verdict (no independent human review; the verdict name itself records this) with a risk-record comment bound to the exact head.
  • regression-risk — fix with material regression risk; requires one assigned independent domain reviewer whose authenticated exact-head APPROVED review the gate verifies (extra:independent:<login>; the token alone never suffices).
  • high-risk — large refactor, feature, or materially high-risk change (security/auth/install/remove/public API/destructive lifecycle/architecture); requires one assigned independent domain reviewer with an authenticated exact-head APPROVED review (extra:independent:<login>).

GJC verdict

gajae.pr-review-verdict.v1 merge-self-approved sha256:08b7bde1f1474ac7e6190d9111fdff9fb53819ca35c98e7c77d6fa41111c8470 reviewer:human reviewer-id:Yeachan-Heo evidence:issue 5326 exact parent/head reproduction plus 20 repeated affected-suite passes and package check/build

  • Target branch is dev
  • bun check passes
  • Tested locally
  • CHANGELOG updated (if user-facing) — test-contract repair only; not user-facing
  • Verdict above matches the exact PR head, not an earlier commit
  • Risk classification above matches the actual review path taken

—
[repo owner's gaebal-gajae (clawdbot) 🦞]

Assistant text presentation reset became a required InteractiveModeContext contract, but seven controller and transcript fixtures still cast incomplete objects through unknown. Hosted shards then failed before reaching their lifecycle assertions.

Provide the required callback in every fixture implicated by run 34001273527 and assert reset ownership on transcript rebuild, committed resume, and successful session replacement paths. Production calls stay strict; no optional fallback masks incomplete contexts.

Lore-id: issue-5326-presentation-fixtures
Constraint: preserve production resetAssistantTextPresentation as a required callback
Constraint: exclude resume-session-reentrancy.test.ts already owned by PR #5323
Rejected: optional chaining in production | would hide invalid runtime contexts
Confidence: high
Scope-risk: narrow
Reversibility: clean
Tested: seven affected suites 20 repeated passes; coding-agent package check; coding-agent package build
Not-tested: full coding-agent shard matrix
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@Yeachan-Heo

Copy link
Copy Markdown
Owner Author

gajae.pr-self-review.v1 verdict:merge-self-approved base:ed67422699299b0257dd45ec1d37167b474b4918 head:34f9845278a47599340581f05f6e193029ae082a sha256:08b7bde1f1474ac7e6190d9111fdff9fb53819ca35c98e7c77d6fa41111c8470 reviewer-id:Yeachan-Heo risk:low-risk extra:none evidence:issue 5326 exact parent/head control, strict fixture contract repair, 20 repeated affected-suite passes, package check/build
self-review-signature: sha256:7402dd8368162db5595ac17d5d2fca50b08b3aed66fd8db64a41249f898190de
Signed-off-by: gaebal-gajae (clawdbot) 🦞

—
[repo owner's gaebal-gajae (clawdbot) 🦞]

@Yeachan-Heo

Copy link
Copy Markdown
Owner Author

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

GJC PR #5327 exact-head review evidence v1
Base: ed67422
Head: 34f9845
Architect: CLEAR architecture/product/code; APPROVE; zero findings/blockers. Confirmed required production contract and direct unconditional calls remain unchanged; diff is seven implicated fixtures only; PR #5323-owned fixture excluded.
Executor QA/red-team: passed e2e and adversarial review; zero blockers. Seven-file union 56/56 passed with 225 assertions. Explicit cases passed for failed replacement no-reset, successful /new and /drop exactly-once reset, committed resume exactly-once reset, pre-mutation cancellation no-reset, transcript rebuild exactly-once reset, and ordered session deletion reset.
Local gates: 20 repeated affected-union passes; coding-agent check pass; coding-agent build pass.
Exact-head contract: PR contract bootstrap and latest Validate exact-head PR contract succeeded.
-----BEGIN PGP SIGNATURE-----

iHUEARYIAB0WIQQE16ZuzjuAE7BguBSIF/QUP4T15wUCapzH1wAKCRCIF/QUP4T1
5x/NAQCbNFm4NvLYNlOeXZH+vf+Ls4RucajZvfULdIqjajbbeQD/b5UwsqtLPuUW
OWYAVAByqlqi7hcVPQP2eh+4jmM16wI=
=uWMb
-----END PGP SIGNATURE-----

—
[repo owner's gaebal-gajae (clawdbot) 🦞]

@Yeachan-Heo

Copy link
Copy Markdown
Owner Author

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

GJC PR #5327 signed postmerge receipt v1
Base: ed67422
Fix head: 34f9845
Merge/dev: c10db31
Merge topology: exact two-parent merge of base and fix head
Issue: #5326 closed at 2026-09-06T01:58:15Z
Targeted postmerge verification at exact merge: seven affected files 56 pass / 0 fail / 225 assertions; coding-agent binary build passed.
Postmerge Dev CI: run 34005224531 completed FAILURE. This is not reported as global success.
Resolved signature evidence: shard 3 job 101411818117 and shard 5 job 101411818086 now succeed; the postmerge failed logs contain no resetAssistantTextPresentation failure in the seven PR #5327 fixtures. Exact-head PR contract/bootstrap and all PR-head checks passed before merge.
Remaining failures are separate and routed precisely:

iHUEARYIAB0WIQQE16ZuzjuAE7BguBSIF/QUP4T15wUCapzPoQAKCRCIF/QUP4T1
57PNAQDICmf5Cgxj/swtnCM3ZKPAXlS1T+sKGqkf54xE9dzakAD/SMvPDukBNsS3
F2Fb4HyzPY0LCrikcQ9zf+Bbgi/aMA0=
=14R6
-----END PGP SIGNATURE-----

—
[repo owner's gaebal-gajae (clawdbot) 🦞]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant