Repository navigation
test(coding-agent): restore presentation reset fixtures - #5327
Conversation
Assistant text presentation reset became a required InteractiveModeContext contract, but seven controller and transcript fixtures still cast incomplete objects through unknown. Hosted shards then failed before reaching their lifecycle assertions. Provide the required callback in every fixture implicated by run 34001273527 and assert reset ownership on transcript rebuild, committed resume, and successful session replacement paths. Production calls stay strict; no optional fallback masks incomplete contexts. Lore-id: issue-5326-presentation-fixtures Constraint: preserve production resetAssistantTextPresentation as a required callback Constraint: exclude resume-session-reentrancy.test.ts already owned by PR #5323 Rejected: optional chaining in production | would hide invalid runtime contexts Confidence: high Scope-risk: narrow Reversibility: clean Tested: seven affected suites 20 repeated passes; coding-agent package check; coding-agent package build Not-tested: full coding-agent shard matrix
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
gajae.pr-self-review.v1 verdict:merge-self-approved base:ed67422699299b0257dd45ec1d37167b474b4918 head:34f9845278a47599340581f05f6e193029ae082a sha256:08b7bde1f1474ac7e6190d9111fdff9fb53819ca35c98e7c77d6fa41111c8470 reviewer-id:Yeachan-Heo risk:low-risk extra:none evidence:issue 5326 exact parent/head control, strict fixture contract repair, 20 repeated affected-suite passes, package check/build — |
|
-----BEGIN PGP SIGNED MESSAGE----- GJC PR #5327 exact-head review evidence v1 iHUEARYIAB0WIQQE16ZuzjuAE7BguBSIF/QUP4T15wUCapzH1wAKCRCIF/QUP4T1 — |
|
-----BEGIN PGP SIGNED MESSAGE----- GJC PR #5327 signed postmerge receipt v1
iHUEARYIAB0WIQQE16ZuzjuAE7BguBSIF/QUP4T15wUCapzPoQAKCRCIF/QUP4T1 — |
What
Restore the required
resetAssistantTextPresentationcallback in the seven incompleteInteractiveModeContextfixtures implicated by dev CI run 34001273527, and assert reset ownership on transcript rebuild, committed resume, and successful session replacement paths.Closes #5326.
Why
Production
InteractiveModeimplements this required callback, and production transcript/session replacement callers invoke it unconditionally. The affected tests cast incomplete fixture objects throughunknown, so they failed before exercising their actual lifecycle assertions.Both exact failing dev
ed67422699299b0257dd45ec1d37167b474b4918and first parent26ac49874df6001cb57e8a3296a8ddece43c8c8creproduce 30 missing-method errors across the seven suites. Coding-agent source/tests are identical across that merge, proving PR #5317 exposed rather than introduced the defect.Overlap was checked before implementation. PR #5323 independently owns
resume-session-reentrancy.test.ts; this PR does not touch or duplicate it. PRs #5313, #5283, and #5321 do not repair these seven fixtures.Distinct run failures in
mcp-lifecycle-cleanup.test.tsandgjc-plugin-runtime-adapters.test.tsreproduce independently and remain classified outside #5326.Testing
bun --cwd=packages/coding-agent run checkbun --cwd=packages/coding-agent run build34f9845278a47599340581f05f6e193029ae082ais GPG-signed and locally verifiedRisk classification
low-risk— ordinary fix/maintenance; the repository owner may use the explicitmerge-self-approvedsolo verdict (no independent human review; the verdict name itself records this) with a risk-record comment bound to the exact head.regression-risk— fix with material regression risk; requires one assigned independent domain reviewer whose authenticated exact-headAPPROVEDreview the gate verifies (extra:independent:<login>; the token alone never suffices).high-risk— large refactor, feature, or materially high-risk change (security/auth/install/remove/public API/destructive lifecycle/architecture); requires one assigned independent domain reviewer with an authenticated exact-headAPPROVEDreview (extra:independent:<login>).GJC verdict
devbun checkpasses—
[repo owner's gaebal-gajae (clawdbot) 🦞]