Action scripts by Gofannon · Pull Request #41 · YunoHost-Apps/dokuwiki_ynh

Gofannon · 2018-09-28T21:12:39Z

Problem

Add "action scripts" => commited, should work
Add "config panel" => Not in the PR, does not run for now

Work in progress. Not ready to merge ! Is used to show progress and let the Apps team work is ongoing

action scripts

To test it:

yunohost app action list dokuwiki

yunohost app action run dokuwiki public_private -a is_public=1 --debug
yunohost app action run dokuwiki public_private -a is_public=0 --debug

yunohost app action run dokuwiki internal_users -a is_internal_users=1 --debug
yunohost app action run dokuwiki internal_users -a is_internal_users=0 --debug

Followed examples

Solution

PR Status

Validation

Minor decision

Upgrade previous version :
Code review : Maniack C
Approval (LGTM) : Maniack C
Approval (LGTM) : Kay0u
CI succeeded :
When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

maniackcrudelis · 2019-03-10T14:00:35Z

 final_path=$(ynh_app_setting_get $app final_path)

+auth_backend=$(ynh_app_setting_get $app auth_backend)
+#is_internal_users=$(ynh_app_setting_get $app is_internal_users)


You should probably uncomment is_internal_users, as you check it after.

maniackcrudelis · 2019-03-10T14:00:55Z

+if [ -z "$is_internal_users" ]; then
+	ynh_app_setting_set $app is_internal_users 0
+fi
+


A test is needed as well for auth_backend

maniackcrudelis · 2019-03-10T14:03:02Z

+#=================================================
+
+# Get authentication backend and set as lowercase
+#auth_backend=${YNH_ACTION_IS_INTERNAL_USERS,,}


This line should be removed I guess.

maniackcrudelis · 2019-03-10T14:05:02Z

+# Plugin "authchained" needs to be installed for this script to run
+if [ ! -d $final_path/lib/plugins/authchained ]; then
+    ynh_die "Plugin 'authchained' is not installed and must be installed beforehand." 1
+fi


Small "typo", but those 2 previous check should be in "# CHECK IF ARGUMENTS AND REQUIREMENTS ARE CORRECT"

maniackcrudelis · 2019-03-10T14:07:58Z

+
+
+# Regen ssowat configuration
+yunohost app ssowatconf


Unneeded I think

maniackcrudelis · 2019-03-10T14:08:28Z

+# RELOAD NGINX
+#=================================================
+
+systemctl reload nginx


Don't think you need that either.

maniackcrudelis · 2019-03-10T14:09:44Z

Not tested, but looks good.

kay0u · 2019-04-17T07:50:41Z

_bump

Add this setting even if not use by default. Only usefull with "internal_users" script. Harmless and makes the maintenance easier

Gofannon · 2019-05-13T12:09:28Z

Can be reviewed and tested.

What has been tested on a VM

Install a new "master branch" dokuwiki
Upgrade using the PR
Upgrade again
Multiple combination of the following:

yunohost app action list dokuwiki

yunohost app action run dokuwiki public_private -a is_public=1 --debug
yunohost app action run dokuwiki public_private -a is_public=0 --debug

yunohost app action run dokuwiki internal_users -a is_internal_users=1 --debug
yunohost app action run dokuwiki internal_users -a is_internal_users=0 --debug

Gofannon · 2019-05-15T18:03:31Z

merge conflicts solved

Gofannon · 2019-05-23T15:54:11Z

bump

kay0u

LGTM

Gofannon · 2019-07-05T10:33:17Z

Following the release of YunoHost 3.6, shall I use TOML instead of JSON?

maniackcrudelis · 2019-07-05T16:16:58Z

It's supposed to work with json and toml. But, it's clearly easier to read in toml. So would be better for long term support to write directly in toml

…o action_scripts

…nfusing

ericgaspar · 2024-05-14T10:48:02Z

!testme

yunohost-bot · 2024-05-14T10:48:04Z

Living in the future, are we?

yunohost-bot · 2024-05-14T10:48:05Z

✌️

Gofannon added 3 commits September 28, 2018 23:01

[enh] Add variable to handle authentication backend

bd578c0

[enh] initial version of "actions scripts"

fb981af

Preload authchained config

1f8f545

maniackcrudelis reviewed Mar 10, 2019

View reviewed changes

maniackcrudelis previously approved these changes Mar 10, 2019

View reviewed changes

maniackcrudelis requested a review from a team March 10, 2019 14:09

Gofannon added 4 commits May 12, 2019 15:55

[fix] issues spotted durring review

a6c4196

Overload default config for peace of mind

37b7698

Add this setting even if not use by default. Only usefull with "internal_users" script. Harmless and makes the maintenance easier

Add helper "ynh_smart_mktemp"

07a018b

Cleaning

1eaf2df

Gofannon dismissed maniackcrudelis’s stale review via 1eaf2df May 12, 2019 14:02

Gofannon and others added 10 commits May 12, 2019 16:51

cleaning 2

c825710

[enh] Add variable to handle authentication backend

854ba94

[enh] initial version of "actions scripts"

a40ae18

Preload authchained config

3a8b257

[fix] issues spotted durring review

cc96361

Overload default config for peace of mind

f927f2a

Add this setting even if not use by default. Only usefull with "internal_users" script. Harmless and makes the maintenance easier

Add helper "ynh_smart_mktemp"

8a460dc

Cleaning

49b5bf8

cleaning 2

6bd544f

Merge branch 'testing' into action_scripts

f774d68

Merge branch 'testing' into action_scripts

59cf50a

kay0u previously approved these changes May 23, 2019

View reviewed changes

Gofannon added 2 commits January 10, 2020 17:58

Switch to toml and fix scripts

f944371

Merge branch 'action_scripts' of github.com:Gofannon/dokuwiki_ynh int…

50d08c6

…o action_scripts

Gofannon dismissed kay0u’s stale review via 50d08c6 January 13, 2020 21:29

tituspijean marked this pull request as draft September 14, 2022 16:21

alexAubin and others added 3 commits April 3, 2024 22:44

Update manifest.toml: fix "maintainers" key, empty string is hella co…

27e0d31

…nfusing

Auto-update READMEs

1d1a045

Merge branch 'testing' into action_scripts

030e82d

Salamandar force-pushed the testing branch from 1d1a045 to 07b1757 Compare June 23, 2024 17:30

Gofannon mentioned this pull request Jan 27, 2025

New user registration through dokuwiki is disabled #34

Open

Uh oh!

Conversation

Gofannon commented Sep 28, 2018 • edited by kay0u Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

action scripts

Solution

PR Status

Validation

Uh oh!

maniackcrudelis Mar 10, 2019

Choose a reason for hiding this comment

Uh oh!

maniackcrudelis Mar 10, 2019

Choose a reason for hiding this comment

Uh oh!

maniackcrudelis Mar 10, 2019

Choose a reason for hiding this comment

Uh oh!

maniackcrudelis Mar 10, 2019

Choose a reason for hiding this comment

Uh oh!

maniackcrudelis Mar 10, 2019

Choose a reason for hiding this comment

Uh oh!

maniackcrudelis Mar 10, 2019

Choose a reason for hiding this comment

Uh oh!

maniackcrudelis commented Mar 10, 2019

Uh oh!

kay0u commented Apr 17, 2019

Uh oh!

Gofannon commented May 13, 2019

Uh oh!

Gofannon commented May 15, 2019

Uh oh!

Gofannon commented May 23, 2019

Uh oh!

kay0u left a comment

Choose a reason for hiding this comment

Uh oh!

Gofannon commented Jul 5, 2019

Uh oh!

maniackcrudelis commented Jul 5, 2019

Uh oh!

ericgaspar commented May 14, 2024

Uh oh!

yunohost-bot commented May 14, 2024

Uh oh!

yunohost-bot commented May 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Gofannon commented Sep 28, 2018 •

edited by kay0u

Loading