Skip to content

fix: Resolve contact tabs not being searchable and pagination not working #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 5.x
Choose a base branch
from

Conversation

driskell
Copy link

Q A
Bug fix? (use the a.b branch) [x]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL N/A
Related developer documentation PR URL N/A
Issue(s) addressed N/A

Description:

You can't use pagination on the custom objects tabs on contacts - it loads but nothing happens as the ID is incorrect in the template

Steps to test this PR:

  1. Open this PR for testing locally (see docs on testing PRs here)
  2. Create a contact
  3. Create a custom object
  4. Create many custom items of that object (enough to trigger pagination)
  5. Attach those items to a contact
  6. Go to the contact, select the tab, try to paginate, it now works
  7. Try to filter, it now works

Copy link
Contributor

@escopecz escopecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that was a typo. Thanks! 👍

@escopecz
Copy link
Contributor

@driskell would you mind updating the actions/upload-artifact to v4 so the CI would run?

@driskell
Copy link
Author

@escopecz I think because I changed the workflow it now needs approval from you to run. I updated it to v4 upload-artefact

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants