Skip to content

fix: Resolve contact tabs not being searchable and pagination not working #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 5.x
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ jobs:
run: bin/php-cs-fixer fix ${{ env.PLUGIN_DIR }} --config=.php-cs-fixer.php -v --dry-run --show-progress=dots --diff

# - name: PHPSTAN - baseline (debug, enable if you need to regenerate baseline for all PHP versions)
# run: bin/phpstan --configuration=${{ env.PLUGIN_DIR }}/phpstan.neon --generate-baseline=var/logs/phpstan-baseline-${{ matrix.php-versions }}.neon --allow-empty-baseline
# run: bin/phpstan --configuration=${{ env.PLUGIN_DIR }}/phpstan.neon --generate-baseline=var/logs/phpstan-baseline-${{ matrix.php-versions }}.neon --allow-empty-baseline

- name: PHPSTAN
run: bin/phpstan --configuration=${{ env.PLUGIN_DIR }}/phpstan.neon
Expand Down Expand Up @@ -142,7 +142,7 @@ jobs:
# verbose: true

- name: Upload logs as artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: mautic-logs
path: var/logs/
4 changes: 2 additions & 2 deletions Resources/views/SubscribedEvents/Tab/content.html.twig
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
</a>
</div>
</div>
<div class='custom-item-list page-list mt-20' id="{{ namespace }}>">
<div class='custom-item-list page-list mt-20' id="{{ namespace }}">
Loading...
</div>
</div>
Expand All @@ -46,4 +46,4 @@
"{{ currentEntityType }}",
"{{ tabId }}"
);
</script>
</script>