POC: Persist Favorites to a Remote Storage#174
Draft
ddragosd wants to merge 4 commits into
Draft
Conversation
vtsaplin
reviewed
Dec 15, 2023
| console.debug(`Favorites Endpoint: ${this.favoritesEndpoint}`); | ||
| } | ||
|
|
||
| async get_favorites() { |
Collaborator
There was a problem hiding this comment.
Could we consider using camel case for naming methods? Using methods with underscores is unconventional in JavaScript, so we'd need to make an exception in our linting rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature persists favorites in remote storage.
TODOs:
Description
The remote storage is implemented in a Runtime action to be able to change the remote store only in one place.
Related Issue
Motivation and Context
To be able to reference the favorites from other surfaces.
Types of changes
Checklist: