-
Notifications
You must be signed in to change notification settings - Fork 5
POC: Persist Favorites to a Remote Storage #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ddragosd
wants to merge
4
commits into
adobe:main
Choose a base branch
from
ddragosd:persist-favs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /* | ||
| * Copyright 2023 Adobe. All rights reserved. | ||
| * This file is licensed to you under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. You may obtain a copy | ||
| * of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under | ||
| * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS | ||
| * OF ANY KIND, either express or implied. See the License for the specific language | ||
| * governing permissions and limitations under the License. | ||
| */ | ||
| const { asGenericAction } = require('../GenericAction.js'); | ||
| const { asAuthAction } = require('../AuthAction.js'); | ||
|
|
||
| const { AppError } = require('../../web-src/src/helpers/ErrorMapper.js'); | ||
|
|
||
| const wretch = require('wretch'); | ||
|
|
||
| async function main(params) { | ||
| const { data } = params; | ||
| try { | ||
| // data is an array of objects, | ||
| // iterate over each object and make a POST reuest to the API endpoing | ||
| // https://hook.app.workfrontfusion.com/cytq82vrakjn5p8xtaashn6gm2qc3jif | ||
| // with the data object as the body | ||
| // return the response from the API | ||
| results = [] | ||
|
|
||
| console.log('saving new variations ...'); | ||
|
|
||
| for (const variant of data) { | ||
| let r = await wretch(`https://hook.app.workfrontfusion.com/cytq82vrakjn5p8xtaashn6gm2qc3jif`) | ||
| .headers({ | ||
| 'Content-Type': 'application/json', | ||
| }) | ||
| .post({ | ||
| data: variant | ||
| }) | ||
| .json(); | ||
| results.push(r); | ||
| } | ||
|
|
||
| return { | ||
| statusCode: 200, | ||
| body: { | ||
| message: 'Favorites updated in API', | ||
| results: results | ||
| } | ||
| }; | ||
| } catch (error) { | ||
| throw new AppError(error, 'FUSION'); | ||
| } | ||
| } | ||
|
|
||
| //exports.main = asAuthAction(asGenericAction(main)); | ||
| exports.main = asGenericAction(main); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| /* | ||
| * Copyright 2023 Adobe. All rights reserved. | ||
| * This file is licensed to you under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. You may obtain a copy | ||
| * of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under | ||
| * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS | ||
| * OF ANY KIND, either express or implied. See the License for the specific language | ||
| * governing permissions and limitations under the License. | ||
| */ | ||
| import { wretchRetry } from '../helpers/NetworkHelper.js'; | ||
| import { AppError } from '../helpers/ErrorMapper.js'; | ||
|
|
||
| export class RemoteFavoritesService { | ||
| constructor({ | ||
| favoritesEndpoint, | ||
| imsOrg, | ||
| accessToken, | ||
| websiteUrl, | ||
| }) { | ||
| this.favoritesEndpoint = favoritesEndpoint; | ||
| this.imsOrg = imsOrg; | ||
| this.accessToken = accessToken; | ||
| this.websiteUrl = websiteUrl; | ||
|
|
||
| console.debug(`Favorites Endpoint: ${this.favoritesEndpoint}`); | ||
| } | ||
|
|
||
| async get_favorites() { | ||
| return wretchRetry(`${this.websiteUrl}/generated-copy.json`).get().json(); | ||
| } | ||
|
|
||
| async save_favorite(data) { | ||
| try { | ||
| /* eslint-disable-next-line camelcase */ | ||
| const response = await wretchRetry(this.favoritesEndpoint) | ||
| .post({ | ||
| data, | ||
| imsOrg: this.imsOrg, | ||
| accessToken: this.accessToken, | ||
| }) | ||
| .json(); | ||
| return response; | ||
| } catch (error) { | ||
| throw new AppError(error, 'AIO'); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /* | ||
| * Copyright 2023 Adobe. All rights reserved. | ||
| * This file is licensed to you under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. You may obtain a copy | ||
| * of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under | ||
| * the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS | ||
| * OF ANY KIND, either express or implied. See the License for the specific language | ||
| * governing permissions and limitations under the License. | ||
| */ | ||
|
|
||
| import { useApplicationContext } from '../components/ApplicationProvider.js'; | ||
|
|
||
| export const createRemotePersistenceEffect = (key) => ({ setSelf, onSet }) => { | ||
| // Flag to indicate if the setSelf was called for initialization | ||
| let isInitializing = true; | ||
| const { remoteFavoritesService } = useApplicationContext(); | ||
|
|
||
| // load the favorites from the API when the atom is used | ||
| remoteFavoritesService.get_favorites() | ||
| .then((favs) => { | ||
| if (favs != null) { | ||
| const favsData = favs.data; | ||
| // remove items from favsData that have the same "id" value | ||
| const uniqueFavs = favsData.filter((item, index, self) => index === self.findIndex((t) => ( | ||
| t.id === item.id | ||
| ))); | ||
| // for each item in uniqueFavs, covert "content" field from string to json | ||
| uniqueFavs.forEach((item) => { | ||
| // eslint-disable-next-line no-param-reassign | ||
| item.content = JSON.parse(item.content); | ||
| }); | ||
| setSelf(uniqueFavs); | ||
| isInitializing = false; | ||
| } | ||
| }) | ||
| .catch((error) => console.error('Error loading favorites:', error)); | ||
|
|
||
| // save the favorites to the API when the atom is updated | ||
| onSet(async (newValue, _, isReset) => { | ||
| // if newValue's array length is 0, then do return | ||
| if (newValue.length === 0) { | ||
| return; | ||
| } | ||
| if (isReset) { | ||
| return; | ||
| } | ||
|
|
||
| if (isInitializing) { | ||
| return; | ||
| } | ||
|
|
||
| // remove items from favs that have the same "id" value | ||
| const favs = newValue; | ||
| const uniqueFavs = favs.filter((item, index, self) => index === self.findIndex((t) => ( | ||
| t.id === item.id | ||
| ))); | ||
|
|
||
| console.log('Favorites to be stored:', favs); | ||
| await remoteFavoritesService.save_favorite(favs) | ||
| .then((response) => response) | ||
| .then((data) => console.log('Favorites updated in API:', data)) | ||
| .catch((error) => console.error('Error updating favorites:', error)); | ||
| }); | ||
| }; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we consider using camel case for naming methods? Using methods with underscores is unconventional in JavaScript, so we'd need to make an exception in our linting rules.