Fix Play verification file generation #150
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This change will bump the AEPSDK Gradle Plugin version from
gp-3.4.0
togp-3.4.1
Description
What changed
generatePlayConsoleVerificationFile(..)
from whenAEPLibraryPlugin
was applied to theproject.afterEvaluate { … }
block.Caution
This approach makes it so that if you turn the flag on, you need the token locally to even build the project which may not be an optimal development experience
Why it was needed
generatePlayConsoleVerificationFile()
depends on user-supplied DSL values:aepLibrary { enablePlayConsoleVerification = true }
namespace = "com.example.sdk"
GOOGLE_TOKEN
/PLAY_CONSOLE_VERIFICATION_TOKEN
When the plugin executed at apply time those properties were not yet set
(the build script hadn’t been evaluated), so:
enablePlayConsoleVerification
was stillfalse
→ file never generated.configuration problems.
By deferring the generation to
afterEvaluate
we guarantee:enablePlayConsoleVerification
istrue
.Testing locally, now when the
enablePlayConsoleVerification = true
the process fails at the build stage with a missing token error as expectedRelated Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: