Skip to content

Fix Play verification file generation #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix Play verification file generation #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion android/aepsdk-gradle-plugin/aepsdk-gradle-plugin/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
val PLUGIN_VERSION = "3.4.0"
val PLUGIN_VERSION = "3.4.1"
// version and group used for Maven local publishing
group = "com.github.adobe.aepsdk-commons"
version = PLUGIN_VERSION

object Plugins {
const val ANDROID_GRADLE_PLUGIN_VERSION = "8.2.0"
Expand Down
11 changes: 8 additions & 3 deletions ...epsdk-gradle-plugin/src/main/kotlin/com/adobe/marketing/mobile/gradle/AEPLibraryPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ class AEPLibraryPlugin : Plugin<Project> {
override fun apply(project: Project) {
val extension = project.createAepLibraryConfiguration()

if (extension.enablePlayConsoleVerification.getOrElse(false)) {
generatePlayConsoleVerificationFile(project, extension)
}
// Generation of the Play Console verification file is deferred until after the project
// has been fully evaluated so that build scripts have a chance to configure the
// `enablePlayConsoleVerification` flag and required properties such as `namespace`.

// These settings should be applied prior to the Android Gradle plugin evaluating the project.
project.afterEvaluate {
Expand Down Expand Up @@ -73,6 +73,11 @@ class AEPLibraryPlugin : Plugin<Project> {
// Configure additional settings based on the project's configuration.
// These settings include Dokka documentation generation, Spotless code formatting, CheckStyle checks, and common dependencies.
project.afterEvaluate {
// Generate Play Console verification file once the DSL has been evaluated
if (extension.enablePlayConsoleVerification.getOrElse(false)) {
generatePlayConsoleVerificationFile(project, extension)
}

if (!extension.disableCommonDependencies.getOrElse(false)) {
configureCommonDependencies(project, extension)
}
Expand Down