Skip to content

Conversation

@Kanishkavijay39
Copy link
Contributor

  • Fix patchReport to merge existing data with patch data instead of replacing entirely
  • Add getS3Object function to fetch existing report data from S3
  • Implement shallow merge where patch data takes precedence over existing data
  • Update tests to reflect proper PATCH merge behavior
  • Add comprehensive test cases for merge functionality and error handling

Fixes issue where PATCH requests were losing existing report fields that weren't included in the patch payload.

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description. Or if there's no issue created, make sure you
    describe here the problem you're solving.
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

If the PR is changing the API specification:

  • make sure you add a "Not implemented yet" note the endpoint description, if the implementation is not ready
    yet. Ideally, return a 501 status code with a message explaining the feature is not implemented yet.
  • make sure you add at least one example of the request and response.

If the PR is changing the API implementation or an entity exposed through the API:

  • make sure you update the API specification and the examples to reflect the changes.

If the PR is introducing a new audit type:

  • make sure you update the API specification with the type, schema of the audit result and an example

Related Issues

Thanks for contributing!

Kanishka and others added 2 commits October 24, 2025 18:03
- Fix patchReport to merge existing data with patch data instead of replacing entirely
- Add getS3Object function to fetch existing report data from S3
- Implement shallow merge where patch data takes precedence over existing data
- Update tests to reflect proper PATCH merge behavior
- Add comprehensive test cases for merge functionality and error handling

Fixes issue where PATCH requests were losing existing report fields that weren't included in the patch payload.
@github-actions
Copy link

This PR will trigger a patch release when merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants