Skip to content

CodeQL version from qlt.conf.json #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mbaluda
Copy link
Contributor

@mbaluda mbaluda commented May 22, 2024

  • Extract CodeQL version from qlt.conf.json to be used in code_scanning workflow
  • Update CodeQL version to 2.17.3
  • Update qlpack files

@mbaluda mbaluda changed the base branch from main to jeongsoolee09/log-injection-fortified May 22, 2024 15:52
@mbaluda mbaluda changed the title Mbaluda fixed codeql Mbaluda codeql version from conf May 22, 2024
@mbaluda mbaluda changed the title Mbaluda codeql version from conf CodeQL version from qlt.conf.json May 22, 2024
@jeongsoolee09
Copy link
Contributor

Thanks @mbaluda! But I think it's better to upgrade the version to 2.17.3 from 2.15.1 used right now, which is more than 2 minor versions behind. So let's

  • Update CLI version in qlt.conf.json
  • Add _ (don't care) to the use of sourceModel (and friends)
  • Update javascript.sarif.expected if needed

If you agree so please update them! Meanwhile, I'll update the JS pack version to latest in qlpack.yml files under lib, src, and test.

@mbaluda mbaluda changed the base branch from jeongsoolee09/log-injection-fortified to main May 22, 2024 18:30
@mbaluda mbaluda changed the base branch from main to jeongsoolee09/log-injection-fortified May 22, 2024 18:30
@mbaluda mbaluda changed the base branch from jeongsoolee09/log-injection-fortified to main May 22, 2024 19:07
@mbaluda mbaluda changed the base branch from main to jeongsoolee09/log-injection-fortified May 22, 2024 19:21
@mbaluda mbaluda changed the base branch from jeongsoolee09/log-injection-fortified to main May 22, 2024 19:57
@mbaluda mbaluda requested a review from jeongsoolee09 May 22, 2024 19:59
@mbaluda mbaluda changed the base branch from main to jeongsoolee09/log-injection-fortified May 22, 2024 20:19
Copy link
Contributor

@jeongsoolee09 jeongsoolee09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jeongsoolee09 jeongsoolee09 merged commit 91a1d61 into jeongsoolee09/log-injection-fortified May 22, 2024
5 checks passed
@jeongsoolee09 jeongsoolee09 deleted the mbaluda-fixed-codeql branch May 22, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants