Adds support for npm and xsjslib modules
#143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0c89db4.
javascript/frameworks/xsjs/lib/advanced_security/javascript/frameworks/xsjs/XSJSLibModules.qll
Outdated
Show resolved
Hide resolved
javascript/frameworks/xsjs/lib/advanced_security/javascript/frameworks/xsjs/XSJSLibModules.qll
Outdated
Show resolved
Hide resolved
javascript/frameworks/xsjs/lib/advanced_security/javascript/frameworks/xsjs/XSJSLibModules.qll
Outdated
Show resolved
Hide resolved
jeongsoolee09
requested changes
Sep 4, 2024
|
sorry @jeongsoolee09 this PR was not yet ready for review |
- Update CodeQL version - Standardize query ids - Include `.cds` files in the DB - Implement `CdlObject` location in the `.cds` file - Modified `EntityExposedWithoutAuthn` error message to include the name of the exposed element - Modified `SensitiveExposure` error message to include the name of the exposed element
- Update CodeQL version - Standardize query ids - Include `.cds` files in the DB - Implement `CdlObject` location in the `.cds` file - Modified `EntityExposedWithoutAuthn` error message to include the name of the exposed element - Modified `SensitiveExposure` error message to include the name of the exposed element
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -10,7 +10,7 @@ | |||
| function test1(requestParameters) { | |||
| let someParameterValue1 = requestParameters.get("someParameter1"); | |||
| $.response.contentType = "text/html"; | |||
| $.response.setBody(requestParameterHandler(someParameterValue1)); | |||
| $.response.setBody(requestParameterHandler(someParameterValue1)); // js/xsjs-reflected-xss | |||
Check failure
Code scanning / CodeQL
XSJS Reflected XSS High test
| function test4(requestParameters) { | ||
| let someParameterValue4 = requestParameters.get("someParameter4"); | ||
| $.response.contentType = "text/html"; | ||
| $.response.setBody(requestParameterHandler(xssSecure.encodeHTML(someParameterValue4))); |
Check failure
Code scanning / CodeQL
XSJS Reflected XSS High test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
XSJSframework adding support forNPMandxsjslibmodules.npmmodules with$.requireimport syntax (from v2.19.0)@sap/xss-secureXSS sanitizersxsjslibmodules with$.import("relative/path.xsjslib")syntax using literal relative path