Save installed StructureDefinitions in database #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it much faster to list validatable StructureDefinitions in the GUI and the Gazelle webservice.
It works when installing an IG (hooked to the creation of the
NpmPackageVersionResourceEntity) and we removing one (it's linked to theNpmPackageVersionResourceEntityand the SQL server will cascade the DELETE).What doesn't work yet is the update when the IG is updated (i.e. the isCurrent flag will change for existing resources).
It probably doesn't work well with an existing database, but having our own SQL migration on top of the HAPI one is quite some work. Do we have any usecase where the database should really be persisted?
I'm unsure if we should differentiate between the IG version and the StructureDefinition version.Already discussed in #225, we have to use the IG versionWe could also only store validatable StructureDefinitions, that would make it a bit faster. We currently don't need to list non-validatable SDs.
Do we need other info in here?
Not ready to merge.