-
Notifications
You must be signed in to change notification settings - Fork 564
ci: add support for vllm sanity testing on Github #2526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6a57ee4
to
37cf5a2
Compare
cf87fee
to
1ee0442
Compare
1ee0442
to
e4aef71
Compare
Signed-off-by: Anant Sharma <[email protected]>
e4aef71
to
0e209a5
Compare
Signed-off-by: Anant Sharma <[email protected]>
Signed-off-by: Anant Sharma <[email protected]>
Signed-off-by: Anant Sharma <[email protected]>
saturley-hall
approved these changes
Aug 28, 2025
jasonqinzhou
pushed a commit
that referenced
this pull request
Aug 30, 2025
Signed-off-by: Anant Sharma <[email protected]> Co-authored-by: Tushar Sharma <[email protected]> Signed-off-by: Jason Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR introduces CI support for running vLLM sanity checks within the GitHub Actions pipeline. It integrates a .github/workflows/container-validation-backends.yml workflow, ensuring that at minimal, the vLLM end to end functionality is automatically verified every time on public PR's.
This PR also includes build optimizations based on the container strategy DEP, which result in reducing the build time on Github for dynamo vllm container from 1 hour to 20 minutes. Build optimizations include:
Details:
Where should the reviewer start?
Check the Github actions workflow: NVIDIA Github Validation / Build and Test - vllm (push)
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
New Features
Refactor
Chores
Tests