Speed up test_socket_error_dupe and test_socket_error_default tests#573
Open
cuu508 wants to merge 1 commit intoaio-libs:masterfrom
Open
Speed up test_socket_error_dupe and test_socket_error_default tests#573cuu508 wants to merge 1 commit intoaio-libs:masterfrom
cuu508 wants to merge 1 commit intoaio-libs:masterfrom
Conversation
Controller.start() starts a thread and waits for a ready event for 5 seconds (aiosmtpd.controller.DEFAULT_READY_TIMEOUT). If the thread hits an exception, the ready event never comes. The `test_socket_error_dupe` and `test_socket_error_default` tests exercise this scenario, and so each takes full 5 seconds to run. I updated these two tests to pass in a shorter ready_timeout value so they don't hang for as long. This saves ~9 seconds for a full test suite run, per environment.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #573 +/- ##
==========================================
- Coverage 97.86% 97.84% -0.02%
==========================================
Files 23 23
Lines 5701 5701
Branches 766 766
==========================================
- Hits 5579 5578 -1
- Misses 77 79 +2
+ Partials 45 44 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Controller.start() starts a thread and waits for a ready event for 5 seconds (aiosmtpd.controller.DEFAULT_READY_TIMEOUT). If the thread hits an exception, the ready event never comes. The
test_socket_error_dupeandtest_socket_error_defaulttests exercise this scenario, and so each takes full 5 seconds to run. I updated these two tests to pass in a shorter ready_timeout value so they don't hang for as long. This saves ~9 seconds for a full test suite run, per environment.Are there changes in behavior for the user?
No, they just speed up tests.
Related issue number
–
Checklist
{py36,py37,py38,py39}-{nocov,cov,diffcov}, qa, docs{py36,py37,py38,py39}-{nocov,cov,diffcov}{py36,py37,py38,py39}-{nocov,cov,diffcov}, pypy3-{nocov,cov}, qa, docs{py36,pypy3}-{nocov,cov,diffcov}, qapy36-{nocov,cov,diffcov}, qa, docsNEWS.rstfile