Skip to content

Speed up test_socket_error_dupe and test_socket_error_default tests #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cuu508 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Speed up test_socket_error_dupe and test_socket_error_default tests #573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions aiosmtpd/tests/test_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,10 @@ def test_reuse_loop(self, temp_event_loop):
@pytest.mark.skipif(in_wsl(), reason="WSL prevents socket collision")
def test_socket_error_dupe(self, plain_controller, client):
contr2 = Controller(
Sink(), hostname=Global.SrvAddr.host, port=Global.SrvAddr.port
Sink(),
hostname=Global.SrvAddr.host,
port=Global.SrvAddr.port,
ready_timeout=0.5,
)
expectedre = r"error while attempting to bind on address"
try:
Expand All @@ -225,7 +228,10 @@ def test_socket_error_dupe(self, plain_controller, client):
@pytest.mark.skipif(in_wsl(), reason="WSL prevents socket collision")
def test_socket_error_default(self):
contr1 = Controller(Sink())
contr2 = Controller(Sink())
contr2 = Controller(
Sink(),
ready_timeout=0.5,
)
expectedre = r"error while attempting to bind on address"
try:
with pytest.raises(socket.error, match=expectedre):
Expand Down
Loading