Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(airbyte-cdk): Fix Record Filter Validation in ConcurrentDeclarativeSource #45

Merged
merged 2 commits into from
Nov 13, 2024
Merged

fix(airbyte-cdk): Fix Record Filter Validation in ConcurrentDeclarativeSource #45

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08a9bb0
Fix Record Filter Validation in ConcurrentDeclarativeSource
tolik0 Nov 13, 2024
842a5ba
Auto-fix lint and format issues
Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions airbyte_cdk/sources/declarative/concurrent_declarative_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
from airbyte_cdk.sources.declarative.concurrency_level import ConcurrencyLevel
from airbyte_cdk.sources.declarative.declarative_stream import DeclarativeStream
from airbyte_cdk.sources.declarative.extractors import RecordSelector
from airbyte_cdk.sources.declarative.extractors.record_filter import (
ClientSideIncrementalRecordFilterDecorator,
)
from airbyte_cdk.sources.declarative.incremental.datetime_based_cursor import DatetimeBasedCursor
from airbyte_cdk.sources.declarative.interpolation import InterpolatedString
from airbyte_cdk.sources.declarative.manifest_declarative_source import ManifestDeclarativeSource
Expand Down Expand Up @@ -291,6 +294,9 @@ def _stream_supports_concurrent_partition_processing(
if isinstance(record_selector, RecordSelector):
if (
record_selector.record_filter
and not isinstance(
record_selector.record_filter, ClientSideIncrementalRecordFilterDecorator
)
and "stream_state" in record_selector.record_filter.condition
):
self.logger.warning(
Expand Down
Loading