Source Amazon Ads : Migrate Portfolios stream to Portfolio API V3 #53692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
…pe/amazon-ads/migrate-portfolios-v3
DanyloGL
requested changes
Feb 19, 2025
There was a problem hiding this comment.
@topefolorunso, there need to make changes in data format (avoiding breaking changes) and request schema.
…pe/amazon-ads/migrate-portfolios-v3
|
@DanyloGL Please review |
|
@artem1205 take a look at this PR plese. Does it work on top of yours once we merge yours? |
it should work. I guess we can run regression test for this stream only to be sure. will approve after 🟢 |
artem1205
reviewed
Feb 20, 2025
| fields: | ||
| - path: | ||
| - lastUpdatedDate | ||
| value: "{{ format_datetime(record['extendedData']['lastUpdateDateTime'], '%s') }}" |
There was a problem hiding this comment.
please check old format in expected_records.jsonl, it is EPOCH in milliseconds
There was a problem hiding this comment.
Fixed @artem1205
…pe/amazon-ads/migrate-portfolios-v3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/airbytehq/airbyte-internal-issues/issues/10361