Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Amazon Ads : Migrate Portfolios stream to Portfolio API V3 #53692

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Source Amazon Ads : Migrate Portfolios stream to Portfolio API V3 #53692

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9461e92
upgrade porfolios api to v3
topefolorunso Feb 14, 2025
795dfe2
Update source.py
topefolorunso Feb 14, 2025
5fe5e38
fix pendulum
topefolorunso Feb 14, 2025
fe2ea43
fix
topefolorunso Feb 14, 2025
4b22838
Merge branch 'master' of https://github.com/airbytehq/airbyte into to…
topefolorunso Feb 14, 2025
771a6ba
Merge branch 'master' of https://github.com/airbytehq/airbyte into to…
topefolorunso Feb 19, 2025
8c1c076
add pagination
topefolorunso Feb 19, 2025
546a5b4
fix record selector, request body
topefolorunso Feb 19, 2025
8bcb5dd
fix dependency
topefolorunso Feb 19, 2025
230758b
fix portfolio schema
topefolorunso Feb 19, 2025
e1612a7
Merge branch 'master' into tope/amazon-ads/migrate-portfolios-v3
topefolorunso Feb 20, 2025
64c8186
update poetry.lock
topefolorunso Feb 20, 2025
936c9e2
fix datetime format
topefolorunso Feb 21, 2025
efaf76d
Merge branch 'master' of https://github.com/airbytehq/airbyte into to…
topefolorunso Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-amazon-ads/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: c6b0a29e-1da9-4512-9002-7bfd0cba2246
dockerImageTag: 6.2.7
dockerImageTag: 6.3.0
dockerRepository: airbyte/source-amazon-ads
documentationUrl: https://docs.airbyte.com/integrations/sources/amazon-ads
githubIssueLabel: source-amazon-ads
Expand Down
409 changes: 273 additions & 136 deletions airbyte-integrations/connectors/source-amazon-ads/poetry.lock
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions airbyte-integrations/connectors/source-amazon-ads/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
build-backend = "poetry.core.masonry.api"

[tool.poetry]
version = "6.2.7"
version = "6.3.0"
name = "source-amazon-ads"
description = "Source implementation for Amazon Ads."
authors = [ "Airbyte <[email protected]>",]
Expand All @@ -27,7 +27,7 @@ responses = "^0.25"
freezegun = "*"
requests-mock = "*"
pytest-mock = "*"

pendulum = "*"

[tool.poe]
include = [
Expand Down
4 changes: 2 additions & 2 deletions airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/manifest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ definitions:
type: SimpleRetriever
requester:
$ref: "#/definitions/base_requester"
path: v2/portfolios/extended
http_method: GET
path: portfolios/list
http_method: POST
request_headers:
Amazon-Advertising-API-Scope: "{{ stream_slice['profileId'] }}"
Amazon-Advertising-API-ClientId: '{{ config["client_id"] }}'
Expand Down
2 changes: 0 additions & 2 deletions airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
import logging
from typing import Any, List, Mapping, Optional, Tuple

import pendulum

from airbyte_cdk import TState
from airbyte_cdk.models import AdvancedAuth, AuthFlowType, ConfiguredAirbyteCatalog, ConnectorSpecification, OAuthConfigSpecification
from airbyte_cdk.sources.declarative.yaml_declarative_source import YamlDeclarativeSource
Expand Down
1 change: 0 additions & 1 deletion airbyte-integrations/connectors/source-amazon-ads/unit_tests/test_report_streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from functools import partial
from unittest import mock

import pendulum
import pytest
import requests_mock
import responses
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/amazon-ads.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ Information about expected report generation waiting time can be found [here](ht

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:----------------------------------------------------------------------------------------------------------------|
| 6.3.0 | 2025-02-14 | [53692](https://github.com/airbytehq/airbyte/pull/53692) | Migrate stream `Portfolios` to Portfolios API v3 |
| 6.2.7 | 2025-01-25 | [52210](https://github.com/airbytehq/airbyte/pull/52210) | Update dependencies |
| 6.2.6 | 2025-01-18 | [51722](https://github.com/airbytehq/airbyte/pull/51722) | Update dependencies |
| 6.2.5 | 2025-01-11 | [51239](https://github.com/airbytehq/airbyte/pull/51239) | Update dependencies |
Expand Down
Loading