feat: post processing - #350
Conversation
|
Important Review skippedToo many files! This PR contains 133 files, which is 33 over the limit of 100. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (9)
📒 Files selected for processing (133)
You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Automated formatting by clang-format, prettier, and other hooks. See https://pre-commit.ci for details.
|
No actionable suggestions for changed features. |
|
Dlizzio, please note Claude had the following comments after comparing both our attempts. See if any make sense.
|
Looks like all these are currently already fixed |
|
Correction to my last comment: I had the MotionBlur |
I rechecked the current PR head (c837d4e), and the other three are already present as well: Vignette uses pow(max(cos_view, 0.0), ...), DoF uses signed int2 coordinates clamped to the texture bounds, and LUT initializes uint3 dims = 0. These were included in 83b189d. |
|
✅ A pre-release build is available for this PR: |
Summary
[BETA]tag.Integration notes
The upstream head was merged into current Open Shaders
dev, then conflicts were resolved against the current feature buffer, VR upscaling flow, Vanilla Fresnel state, shared HLSL layout, translations, and version metadata.Post Processing is packaged in AIO despite
autoupload = falsethrough explicitaio = truemetadata. Scene Manager remains untouched and feature-agnostic.Validation
Runtime visual validation in Skyrim is still pending, so this PR is opened as a draft.