Follow-up fix for PR#2294 added Hostname to Resolved Mail & SMS #2388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I don't think fixing the Black codestyle of the other files would fit into the PR here. |
1 task
|
Thanks. Looks like this needs to be applied to api/tacticalrmm/checks/models.py as well. |
Contributor
Author
|
Maybe it would be better to define a subject variable and build the full subject/body from it, so you only need to change the subject/body in one place. Gonna Test some Things with it |
Contributor
Author
|
Note: #1965 |
|
Giving the user control over the subject would be awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for PR#2294
added hostname to Resolved Subject for Mail & SMS