tidy(utils): Add printing nested Error objs#2269
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 6, 2025
Cobalt0s
force-pushed
the
cobalt0s/utils-print
branch
from
cf910b8 to
048821e
Compare
This was referenced Nov 7, 2025
anushat05
reviewed
Nov 11, 2025
Contributor
anushat05
left a comment
anushat05
left a comment
There was a problem hiding this comment.
Did we do any sort of testing for us to verify if this util works as expected? Unit tests is also okay
anushat05
reviewed
Nov 11, 2025
Contributor
anushat05
left a comment
anushat05
left a comment
There was a problem hiding this comment.
Also, looks like there are some merge conflicts
Cobalt0s
force-pushed
the
cobalt0s/utils-print
branch
from
048821e to
5f920fe
Compare
anushat05
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves utility code used for printing data structures in live test scripts.
Previously,
ListObjectMetadataResultandBatchWriteResultdisplayed Go errors as{}becauseError()wasn't invoked.Now,
Error()is called recursively, ensuring all errors are rendered as strings.DumpJSON now behaves as a true "universal printer" without modifying the original data.
Live Test
Adding non-existent object name to request Hubspot ObjectMetadata we know that for that object an error will be returned.
As per screenshot the nested error is properly converted to string and thats why it is printed not as
{}but as text: